From: Jason Riedy <ejr@EECS.Berkeley.EDU>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add compat/setenv.c, use in git.c.
Date: Tue, 06 Dec 2005 14:18:25 -0800 [thread overview]
Message-ID: <20475.1133907505@lotus.CS.Berkeley.EDU> (raw)
In-Reply-To: <7vwtih299f.fsf@assigned-by-dhcp.cox.net>
And Morten Welinder writes:
- The code looks wrong. It assumes that pointers are no larger than ints.
The failure's in 32-bit mode, so they _are_ the same size.
The difference is no more than 0x80 in the tests.
But you're right; the result is implementation defined in
C99.
And Junio C Hamano writes:
- Are you suggesting it to be done like this?
Your change fixed it. Oddly enough, using arithmetic in
ptrdiff_t then testing against zero didn't... I don't
have time to dig through assembly or try different gcc
versions to figure out the real problem. ugh.
Jason
next prev parent reply other threads:[~2005-12-06 22:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-02 23:08 [PATCH] Add compat/setenv.c, use in git.c Jason Riedy
2005-12-04 6:26 ` Junio C Hamano
2005-12-04 21:07 ` H. Peter Anvin
2005-12-04 22:24 ` Junio C Hamano
2005-12-04 22:31 ` Junio C Hamano
2005-12-04 23:34 ` H. Peter Anvin
2005-12-05 18:07 ` Jason Riedy
2005-12-05 18:39 ` H. Peter Anvin
2005-12-06 3:35 ` Junio C Hamano
2005-12-06 19:59 ` Jason Riedy
2005-12-06 21:10 ` Morten Welinder
2005-12-06 21:41 ` Junio C Hamano
2005-12-06 22:18 ` Jason Riedy [this message]
2005-12-07 0:58 ` Morten Welinder
2005-12-04 23:01 ` [PATCH] compat/setenv: do not free what we fed putenv(3) Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20475.1133907505@lotus.CS.Berkeley.EDU \
--to=ejr@eecs.berkeley.edu \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.