Re: [PATCH v8] Some automatic NUMA placement documentation

[Ian Jackson <Ian.Jackson@eu.citrix.com>]

Dario Faggioli writes ("Re: [PATCH v8] Some automatic NUMA placement documentation"):
> I think it is. Actually, it was you that suggested turning the code into
> that... :-P
> 
> It's this thing I'm trying to document:
> 
>     if (libxl_defbool_val(info->numa_placement)) {
>         int rc;
> 
>         if (!libxl_bitmap_is_full(&info->cpumap)) {
>             LOG(ERROR, "Can run NUMA placement only if no vcpu "
>                        "affinity is specified");
>             return ERROR_INVAL;
>         }
> 
>         rc = numa_place_domain(gc, domid, info);
>         if (rc)
>             return rc;
>     }
> 
> Am I missing something?

No.  I'm conflating cpupools and vcpu affinity.

Ian.