All of lore.kernel.org
 help / color / mirror / Atom feed
From: Halil Pasic <pasic@linux.ibm.com>
To: Tony Krowiak <akrowiak@linux.vnet.ibm.com>,
	Halil Pasic <pasic@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org
Cc: mjrosato@linux.vnet.ibm.com, peter.maydell@linaro.org,
	alifm@linux.vnet.ibm.com, eskultet@redhat.com, david@redhat.com,
	pmorel@linux.vnet.ibm.com, cohuck@redhat.com,
	heiko.carstens@de.ibm.com, alex.williamson@redhat.com,
	agraf@suse.de, borntraeger@de.ibm.com, qemu-s390x@nongnu.org,
	jjherne@linux.vnet.ibm.com, schwidefsky@de.ibm.com,
	pbonzini@redhat.com, bjsdjshi@linux.vnet.ibm.com,
	eric.auger@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support
Date: Sun, 22 Apr 2018 18:01:39 +0200	[thread overview]
Message-ID: <204d8b6e-0068-d8de-ebe6-2598d136997d@linux.ibm.com> (raw)
In-Reply-To: <bf3ac9e4-1f53-0372-450d-1a84f780d25e@linux.vnet.ibm.com>



On 04/22/2018 05:43 PM, Tony Krowiak wrote:
>>> +    FEAT_INIT_MISC("ap", "AP facilities installed"),
>>
>> Why plural ('facilities')? Would not s/facilities/instructions be more end-user
>> friendly?
> 
> It's a matter of opinion. I prefer facilities because AP is comprised of not only
> instructions, but also AP processors.

Please elaborate. You mean processors like AP cards? If yes what if the matrix is
empty (e.g. the state we decided is the default when no further action is taken
(assign queues to the vfio-ap kernel driver, set up an mdev, -device vfio-ap on
qemu cmd line))?

I just wanted to point out that this plural is very vague. Not speaking about that
QCI should be an AP facility too, but is not included in this 'features' and is not
covered by this cpu model feature. It has it's own cpu model feature and even a
dedicated STFLE bit.

Regards,
Halil

  reply	other threads:[~2018-04-22 16:01 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-15 19:07 [Qemu-devel] [PATCH v4 0/5] s390x: vfio-ap: guest dedicated crypto adapters Tony Krowiak
2018-04-15 19:07 ` [Qemu-devel] [PATCH v4 1/5] linux-headers: linux header updates for AP support Tony Krowiak
2018-04-15 19:07 ` [Qemu-devel] [PATCH v4 2/5] s390x/ap: base Adjunct Processor (AP) object Tony Krowiak
2018-04-18  9:16   ` Pierre Morel
2018-04-22 15:39     ` Tony Krowiak
2018-04-15 19:07 ` [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support Tony Krowiak
2018-04-16 15:44   ` David Hildenbrand
2018-04-17 18:20     ` Tony Krowiak
2018-04-17 18:21     ` Christian Borntraeger
2018-04-18  7:40       ` Cornelia Huck
2018-04-18  8:59         ` David Hildenbrand
2018-04-22 15:41           ` Tony Krowiak
2018-05-03 14:54           ` Tony Krowiak
2018-04-22 15:40         ` Tony Krowiak
2018-04-18 10:55   ` Halil Pasic
2018-04-18 11:03     ` David Hildenbrand
2018-04-18 11:50       ` Pierre Morel
2018-04-22 15:52       ` Tony Krowiak
2018-04-22 15:43     ` Tony Krowiak
2018-04-22 16:01       ` Halil Pasic [this message]
2018-04-22 16:15         ` Tony Krowiak
2018-05-08 10:46         ` Tony Krowiak
2018-04-22 15:52     ` Tony Krowiak
2018-04-22 16:03       ` Halil Pasic
2018-04-15 19:07 ` [Qemu-devel] [PATCH v4 4/5] s390x/vfio: ap: Introduce VFIO AP device Tony Krowiak
2018-04-18  9:11   ` Pierre Morel
2018-04-22 15:55     ` Tony Krowiak
2018-04-19 12:03   ` Cornelia Huck
2018-04-22 16:05     ` Tony Krowiak
2018-04-23  7:00       ` Cornelia Huck
2018-04-26 14:50         ` Tony Krowiak
2018-04-15 19:07 ` [Qemu-devel] [PATCH v4 5/5] s390: doc: detailed specifications for AP virtualization Tony Krowiak
2018-04-15 19:14 ` [Qemu-devel] [PATCH v4 0/5] s390x: vfio-ap: guest dedicated crypto adapters no-reply
2018-04-19 11:51 ` Cornelia Huck
2018-04-22 16:17   ` Tony Krowiak
2018-04-23  7:01     ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=204d8b6e-0068-d8de-ebe6-2598d136997d@linux.ibm.com \
    --to=pasic@linux.ibm.com \
    --cc=agraf@suse.de \
    --cc=akrowiak@linux.vnet.ibm.com \
    --cc=alex.williamson@redhat.com \
    --cc=alifm@linux.vnet.ibm.com \
    --cc=bjsdjshi@linux.vnet.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=eskultet@redhat.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jjherne@linux.vnet.ibm.com \
    --cc=mjrosato@linux.vnet.ibm.com \
    --cc=pasic@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=pmorel@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.