From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] igb_uio: prevent reset for a list of devices Date: Sat, 04 Nov 2017 00:03:32 +0100 Message-ID: <2051591.HpGYabZJN9@xps> References: <20171103223822.28852-1-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Jianfeng Tan , Jingjing Wu , Shijith Thotton , Gregory Etelson , Harish Patil , George Prekas , Sergio Gonzalez Monroy , Rasesh Mody , Lee Roberts To: Ferruh Yigit Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id DF65F1B6A3 for ; Sat, 4 Nov 2017 00:03:35 +0100 (CET) In-Reply-To: <20171103223822.28852-1-ferruh.yigit@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/11/2017 23:38, Ferruh Yigit: > Some devices are having problem on device reset that happens during DPDK > application exit [1]. > > Create a static list of devices and exclude them from device reset. [...] > This is alternative approach to > http://dpdk.org/dev/patchwork/patch/31144/ It is better to change the behaviour only for the misbehaving device, as it is done with this alternative. However as far as I understand, the change is removing a long delay due to the reset, but re-enable a security hole due to the lack of reset. So I think we must have a compilation option anyway, in order to let the packager (or distribution) make this difficult decision. The compilation option could be something like RTE_BNX2X_PREFER_SECURITY_HOLE_THAN_LONG_RESTART Feel free to find a better name :)