All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Wunderlich <sw@simonwunderlich.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Jonathan Haws <jhaws@sdl.usu.edu>
Subject: Re: [B.A.T.M.A.N.] [PATCH] alfred: Externalized synchronization interval
Date: Fri, 12 Aug 2016 10:18:21 +0200	[thread overview]
Message-ID: <2051990.AEtJ42fJkW@prime> (raw)
In-Reply-To: <1469738596-10972-1-git-send-email-jhaws@sdl.usu.edu>

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

On Thursday, July 28, 2016 2:43:16 PM CEST Jonathan Haws wrote:
> Signed-off-by: Jonathan Haws <jhaws@sdl.usu.edu>
> 
> ALFRED_INTERVAL is now externalized via the -p option (synchronization
> period).  If specified as option, user supplied interval is used,
> otherwise the default interval of ALFRED_INTERVAL is used.
[...]
> --- a/server.c
> +++ b/server.c
> @@ -372,7 +372,7 @@ int alfred_server(struct globals *globals)
> 
>  	while (1) {
>  		clock_gettime(CLOCK_MONOTONIC, &now);
> -		now.tv_sec -= ALFRED_INTERVAL;
> +		time_diff(&now, &globals->sync_period, &now);

I believe this at least deserves a comment, or must be made more clear in the 
code.

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2016-08-12  8:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-28 20:43 [B.A.T.M.A.N.] [PATCH] alfred: Externalized synchronization interval Jonathan Haws
2016-08-06 16:38 ` Sven Eckelmann
2016-08-10 19:59   ` Jonathan Haws
2016-08-12  8:20     ` Simon Wunderlich
2016-08-12  8:18 ` Simon Wunderlich [this message]
2016-08-15 14:59   ` Jonathan Haws
2016-08-15 15:09     ` Simon Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2051990.AEtJ42fJkW@prime \
    --to=sw@simonwunderlich.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=jhaws@sdl.usu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.