All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sujith Manoharan <c_manoha@qualcomm.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: Sujith Manoharan <c_manoha@qualcomm.com>,
	<linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [RFC 6/7] ath9k_hw: Program correct PLL value for AR9565
Date: Sat, 8 Sep 2012 13:47:56 +0530	[thread overview]
Message-ID: <20554.65332.70163.2580@gargle.gargle.HOWL> (raw)
In-Reply-To: <504AFCE8.5010306@openwrt.org>

Felix Fietkau wrote:
> That looks messed up, how about just:
> 
> 	pll = ath9k_hw_compute_pll_control(ah, chan);
> 	if (AR_SREV_9565(ah))
> 		pll |= 0x40000;
> 	REG_WRITE(ah, AR_RTC_PLL_CONTROL, pll);
> 
> Or alternatively move that OR mask into ath9k_hw_compute_pll_control

[RFC v2] ath9k_hw: Program correct PLL value for AR9565

Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath9k/hw.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
index 063d724..47de1a9 100644
--- a/drivers/net/wireless/ath/ath9k/hw.c
+++ b/drivers/net/wireless/ath/ath9k/hw.c
@@ -918,7 +918,8 @@ static void ath9k_hw_init_pll(struct ath_hw *ah,
 	}
 
 	pll = ath9k_hw_compute_pll_control(ah, chan);
-
+	if (AR_SREV_9565(ah))
+		pll |= 0x40000;
 	REG_WRITE(ah, AR_RTC_PLL_CONTROL, pll);
 
 	if (AR_SREV_9485(ah) || AR_SREV_9340(ah) || AR_SREV_9330(ah) ||
-- 
1.7.12


      reply	other threads:[~2012-09-08  8:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-08  7:28 [RFC 6/7] ath9k_hw: Program correct PLL value for AR9565 Sujith Manoharan
2012-09-08  8:08 ` Felix Fietkau
2012-09-08  8:17   ` Sujith Manoharan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20554.65332.70163.2580@gargle.gargle.HOWL \
    --to=c_manoha@qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=nbd@openwrt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.