All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: "Peter A. Bigot" <pab@pabigot.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: qt4-x11-free dependence on gtk+
Date: Fri, 30 Aug 2013 14:37:13 +0100	[thread overview]
Message-ID: <2056053.nfWMgOXbJx@helios> (raw)
In-Reply-To: <521CF70C.2050100@pabigot.com>

Hi Peter,

On Tuesday 27 August 2013 13:59:24 Peter A. Bigot wrote:
> Since "bitbake qt4-x11-free" failed for me until I did "bitbake gtk+",
> qt4-x11-free needs some sort of dependency on gtk+ to avoid the failure
> below.  I'm guessing it's something like the following added to
> qt4-x11-free.inc:
> 
> PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'x11', 'gtk', '',
> d)}"
> PACKAGECONFIG[gtk] = "-gtkstyle,-no-gtkstyle,gtk+"
> 
> but since it takes about an hour to build qt4-x11-free on my system I'm
> hoping somebody can tell me whether that's the right approach.

This seems reasonable to me. I can't actually reproduce the failure, but I can 
see how the dependency comes in and it does look to be on by default.

Looking at bitbake -g output (for master at least) it seems like gtk+3 will 
always be built by default when building qt4-x11-free because pulseaudio 
depends upon it, so that explains how this problem doesn't often come up. Of 
course if gtk+3 is rebuilding when qt4-x11-free is in do_compile, or you've 
disabled pulseaudio, then this issue will occur so we do need to do something 
such as the above. I think the PACKAGECONFIG option for this should be called 
"gtkstyle" rather than just "gtk" to give a better idea of what it's enabling 
though. Would you please send an actual patch to add this?

Thanks,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


  reply	other threads:[~2013-08-30 13:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-27 18:59 qt4-x11-free dependence on gtk+ Peter A. Bigot
2013-08-30 13:37 ` Paul Eggleton [this message]
2013-08-31  8:40   ` Peter A. Bigot
2013-09-04 10:56     ` Paul Eggleton
2013-09-04 11:20       ` Peter A. Bigot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2056053.nfWMgOXbJx@helios \
    --to=paul.eggleton@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=pab@pabigot.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.