From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: LPM6 next hop size Date: Wed, 21 Sep 2016 21:37:08 +0200 Message-ID: <2058475.LZrEOEsCyO@xps13> References: <3263960.cPWMKkvuZx@xps13> <20160921172905.GA7158@mhcomputing.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Matthew Hall , Nikita Kozlov Return-path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id AF4D85686 for ; Wed, 21 Sep 2016 21:37:10 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id b130so109762769wmc.0 for ; Wed, 21 Sep 2016 12:37:10 -0700 (PDT) In-Reply-To: <20160921172905.GA7158@mhcomputing.net> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-09-21 10:29, Matthew Hall: > On Tue, Sep 20, 2016 at 10:11:04PM +0200, Thomas Monjalon wrote: > > Please, will you help reviewing this patch? > > Sure. > > 1. It adds a dependency on libbsd on Linux: bsd/sys/tree.h. Is this an > expected dependency of DPDK already? I use it in my code but not sure it's > expected for everybody else. No we don't use libbsd yet. Is there a clean way to avoid this new dependency? What are the pros/cons? [...] > 7. Some of us previous submitted code to expand LPM4 and LPM6 to 24 bit next > hop but the current code is only doing 16 bit. This is not pleasant for me > because I really need the 24-bit support. When can we make this happen? It will happen as soon as a patch is approved. Matthew, what happened to your own patch for 24-bit hop? Please do not hesitate to work together if it can accelerate landing this feature.