All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
	christoffer dall <christoffer.dall@linaro.org>,
	marc zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH kvm-unit-tests] arm: fix crash when caches are off
Date: Tue, 16 Sep 2014 08:51:06 -0400 (EDT)	[thread overview]
Message-ID: <205961557.5030289.1410871866191.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <5418315B.6020201@redhat.com>



----- Original Message -----
> Il 16/09/2014 14:43, Andrew Jones ha scritto:
> > I don't think we need to worry about this case. AFAIU, enabling the
> > caches for a particular cpu shouldn't require any synchronization.
> > So we should be able to do
> > 
> >     enable caches
> >     spin_lock
> >     start other processors
> >     spin_unlock
> 
> Ok, I'll test and apply your patch then.

Actually, yeah, please apply now in order to get A7 boards working.
I'll do a follow-on patch to fix the case above (which will require
deciding how to hand per cpu data).

drew

> 
> Once you change the code to enable caches, please consider hanging on
> spin_lock with caches disabled.
> 
> Paolo
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2014-09-16 12:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-16  2:06 [PATCH kvm-unit-tests] arm: fix crash when caches are off Andrew Jones
2014-09-16  8:14 ` Paolo Bonzini
2014-09-16 12:12   ` Andrew Jones
2014-09-16 12:28     ` Paolo Bonzini
2014-09-16 12:43       ` Andrew Jones
2014-09-16 12:47         ` Paolo Bonzini
2014-09-16 12:51           ` Andrew Jones [this message]
2014-09-16 14:38             ` Andrew Jones
2014-09-16 18:04               ` Andrew Jones
2014-09-16 12:57           ` Andrew Jones
2014-09-26  7:51             ` Christoffer Dall
2014-10-30 15:59               ` Andrew Jones
2014-09-16 12:48         ` Andrew Jones
2014-09-18 10:36 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=205961557.5030289.1410871866191.JavaMail.zimbra@redhat.com \
    --to=drjones@redhat.com \
    --cc=christoffer.dall@linaro.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=marc.zyngier@arm.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.