From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:504:5f65:b0:1be9:327d:8ee3 with SMTP id gl5csp3278470njc; Wed, 26 Mar 2025 05:40:20 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCU8Lv9ZNMBA2qP36k602B5NmBuM4XlxPWiTdjmZJOPWOeT7t63MrqjIK/AK4AEM1T3V9F+vSEt2Iy14vg==@linaro.org X-Google-Smtp-Source: AGHT+IEjHFnd+/Bzb0oFJh1NAySjuOLU7wJ2t+vbRUMfgYDd1hcvFNYP0CcdGJxMlioKrzYJC/sf X-Received: by 2002:a05:622a:510a:b0:474:e66e:3955 with SMTP id d75a77b69052e-4771ddc11aemr289570641cf.25.1742992820451; Wed, 26 Mar 2025 05:40:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1742992820; cv=none; d=google.com; s=arc-20240605; b=XnjQIIgxpAhroKYCqe4uDLDcf/hIWFFbIuu0k7lnFjTDWwpgLku4qS+roGOLqEhwvI 1noqr/t3cVLFVdADraaMZgejQviITM3Rv2fif/KDPeuOy2VV5pOZ+p0fAhA+fok9Ztx3 XSzMS1aNRqpBrv9WUIGxlYWpdPcQfTgc/9fvzLQrfOtn1WL0CFEoP9hF33JrZX8FFbHW sFwwykCR6UgegwCmDolaZEfyNw2upTSwwV1MKkxgBvmw1zu1Gg/EuVNFoCUfaYyRNAjC pslUk3Rb32aA0mmfDFcCUF2Ycd0AVGPAbgKmutcjuSwrNYKm/LF2zOCRFbsd6h56+rfy aRXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:references :message-id:in-reply-to:subject:cc:to:from:date; bh=zPZg0+JZTwnuMFo0C/AdGqtc/zwMz0LOfsgK8yfyTyQ=; fh=kdW7fUaHhRc30l/QU8/yfl8Y9R45l1b6TF4S9XGyBAY=; b=dESNdxbvXgXeLv6LRvsC9maF5f3Lrz86uQn5LqOY2+zsqv8wLclc7watalwHo6S8rf 1GETosh7MM2Fz/LZ3iEZg0Yq1K4NiYj8aUVDG3jlTbunUT6Uj0rpgX4iZdmXYn18mWFi zsXTTQKhugPIs6CeNm9Thxt5/S3K2LVpXY3Zk9xNQExijljYjwPt0qk9dgf1ZyI4qbJk vGGBe6XTrMw1YUMUtvTaj4+QKFr4BZyyaQHYSH8z+A4zQJZrtgwYL5XwYygkUyJrIu+O IATFq3oZq3I2UpOQgWQm8K5TLvwUv9N0v7c8mLKbj3/sVZVQhGpY9eXY+CSrETCjq2CI Q3AQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=eik.bme.hu Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-4771d15b297si112708231cf.103.2025.03.26.05.40.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Mar 2025 05:40:20 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=eik.bme.hu Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1txQ3G-0004Hj-Hc; Wed, 26 Mar 2025 08:40:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txQ3B-0004ED-JV; Wed, 26 Mar 2025 08:40:06 -0400 Received: from zero.eik.bme.hu ([152.66.115.2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txQ35-0000BA-SI; Wed, 26 Mar 2025 08:40:02 -0400 Received: from zero.eik.bme.hu (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 7F3584E6019; Wed, 26 Mar 2025 13:39:51 +0100 (CET) X-Virus-Scanned: amavisd-new at eik.bme.hu Received: from zero.eik.bme.hu ([127.0.0.1]) by zero.eik.bme.hu (zero.eik.bme.hu [127.0.0.1]) (amavisd-new, port 10028) with ESMTP id d8QRc5ugYFNh; Wed, 26 Mar 2025 13:39:49 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 67CFF4E6005; Wed, 26 Mar 2025 13:39:49 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 6596674577C; Wed, 26 Mar 2025 13:39:49 +0100 (CET) Date: Wed, 26 Mar 2025 13:39:49 +0100 (CET) From: BALATON Zoltan To: Thomas Huth cc: =?ISO-8859-15?Q?Philippe_Mathieu-Daud=E9?= , qemu-devel@nongnu.org, Ilya Leoshkevich , =?ISO-8859-15?Q?Herv=E9_Poussineau?= , Matthew Rosato , Gerd Hoffmann , Glenn Miles , Samuel Tardieu , qemu-block@nongnu.org, Patrick Leis , David Hildenbrand , "Edgar E. Iglesias" , Tyrone Ting , Eric Farman , Christian Borntraeger , Peter Maydell , Halil Pasic , Richard Henderson , Kevin Wolf , Alistair Francis , Bernhard Beschow , Hanna Reitz , Hao Wu , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org Subject: Re: [PATCH-for-10.0 01/12] hw/audio/wm8750: Categorize and add description In-Reply-To: Message-ID: <205e31d4-9dc5-dfec-f012-94b3ee9dfa2a@eik.bme.hu> References: <20250325224310.8785-1-philmd@linaro.org> <20250325224310.8785-2-philmd@linaro.org> <892797b6-8d2f-4234-840f-e36ef94b0701@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3866299591-1374366407-1742992789=:46948" Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: YEIn5Ov0Z9g/ This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --3866299591-1374366407-1742992789=:46948 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Wed, 26 Mar 2025, Thomas Huth wrote: > On 26/03/2025 07.47, Thomas Huth wrote: >> On 25/03/2025 23.42, Philippe Mathieu-Daudé wrote: >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>>   hw/audio/wm8750.c | 2 ++ >>>   1 file changed, 2 insertions(+) >>> >>> diff --git a/hw/audio/wm8750.c b/hw/audio/wm8750.c >>> index 8d381dbc658..6c1bb20fb75 100644 >>> --- a/hw/audio/wm8750.c >>> +++ b/hw/audio/wm8750.c >>> @@ -721,6 +721,8 @@ static void wm8750_class_init(ObjectClass *klass, void >>> *data) >>>       sc->send = wm8750_tx; >>>       dc->vmsd = &vmstate_wm8750; >>>       device_class_set_props(dc, wm8750_properties); >>> +    set_bit(DEVICE_CATEGORY_SOUND, dc->categories); >>> +    dc->desc = "WM8750 Stereo CODEC"; >>>   } >>>   static const TypeInfo wm8750_info = { >> >> Reviewed-by: Thomas Huth > > Looking at this twice, I think the patch is not OK in its current shape: The > wm8750 device now shows up twice in the output of "-device help", once in the > "Sound" category and once in the "Misc" category (inherited from I2C device). > That's somewhat ugly. I guess you'd need to remove the MISC bit here to clean > that up? Maybe we could add an i2c category for those devices? But in this case it fits in multiple categories. Regards, BALATON Zoltan --3866299591-1374366407-1742992789=:46948--