From: David Howells <dhowells@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] switch frw to use local_soft_irq_pending
Date: Mon, 17 Jan 2005 12:14:37 +0000 [thread overview]
Message-ID: <20621.1105964077@redhat.com> (raw)
In-Reply-To: <20050116115841.GB13716@lst.de>
Christoph Hellwig <hch@lst.de> wrote:
> The newly merged frv do_IRQ code calls softirq_pending(), but always with
> the current cpu as argument - switch to local_softirq_pending().
>
> Btw, this usage look bogus to me, any reason you need to call do_softirq
> again after you did four lines above in irq_exit(), David?
Because irq_exit() doesn't call do_softirq() in 2.4 where I developed this
arch in the first place. And because 2.6 didn't malfunction due to
do_softirq() being called twice, I didn't notice.
Actually... it's probably also bad that it calls irq_exit() first and then
__clr_MASK(). That means it runs softirq processing with at least one
interrupt level disabled:-/
David
prev parent reply other threads:[~2005-01-17 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-16 11:58 [PATCH 2/3] switch frw to use local_soft_irq_pending Christoph Hellwig
2005-01-17 12:14 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20621.1105964077@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.