From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A23BAC433B4 for ; Thu, 20 May 2021 02:00:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7693D611BD for ; Thu, 20 May 2021 02:00:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230197AbhETCBi (ORCPT ); Wed, 19 May 2021 22:01:38 -0400 Received: from linux.microsoft.com ([13.77.154.182]:60098 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229808AbhETCBh (ORCPT ); Wed, 19 May 2021 22:01:37 -0400 Received: from [192.168.254.32] (unknown [47.187.214.213]) by linux.microsoft.com (Postfix) with ESMTPSA id 95B3A20B7178; Wed, 19 May 2021 19:00:16 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 95B3A20B7178 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1621476017; bh=U8QEKQGFiRQOQLEHv8ObhS4iuMjm72aPIoLD5Z21rRg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=NgTZCCwk+NyZJh/Q5+8WXfReGR4mxTpJnXOqpoNZOmnLZQ7bIO4nCxxUkvtVtptaF MyivxqYXEA+qoVEVQ7A43OSK60aAKmXZaGdi/NUZUwciCqMRdsGgbQCChSFczo9LPI 9cwM+2aY2NnzBKrJA1lmL9Wn/mB+rQuUCTzlJ4Y0= Subject: Re: [RFC PATCH v4 2/2] arm64: Create a list of SYM_CODE functions, blacklist them in the unwinder To: Mark Brown Cc: mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, jthierry@redhat.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org References: <68eeda61b3e9579d65698a884b26c8632025e503> <20210516040018.128105-1-madvenka@linux.microsoft.com> <20210516040018.128105-3-madvenka@linux.microsoft.com> <20210519192730.GI4224@sirena.org.uk> From: "Madhavan T. Venkataraman" Message-ID: <2067fb27-34ba-8b7e-e6ef-505796316970@linux.microsoft.com> Date: Wed, 19 May 2021 21:00:15 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210519192730.GI4224@sirena.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org Thanks a lot! Madhavan On 5/19/21 2:27 PM, Mark Brown wrote: > On Sat, May 15, 2021 at 11:00:18PM -0500, madvenka@linux.microsoft.com wrote: >> From: "Madhavan T. Venkataraman" >> >> The unwinder should check if the return PC falls in any function that >> is considered unreliable from an unwinding perspective. If it does, >> mark the stack trace unreliable. > > Other than the naming issue this makes sense to me, I'll try to go > through the first patch properly in the next few days. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1367AC433ED for ; Thu, 20 May 2021 02:02:51 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE752611AE for ; Thu, 20 May 2021 02:02:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE752611AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hWQQqMsfY9Qqvh14YcB4FdGWDCYYaXOiHzay61Jm31s=; b=J04J+kQGsyW4L890kSw26tR7k eQBJyCIF34zYV17G8tRi22NCM2pU3JBMv/T8or3BA+7m/bxHG14iYm12YnhukjOe7oBUAmstm5sIp sbBIvNLPaH9yzH0W35nSEpS01Q9YhfFOP1L0SQic8hMZ+F+ynbWHYwAWZlMSmAgXGTjgs2U+kcMC+ 40OWXnABvPx7oVVBAE2fS4AfQ2mEZFDdReKkY3V1Oz2Lhst+uFR3K6zRM/WsuIaNauUG7KvuW7I5R NtABd2Fo85MZO5BdCubcIUJrajGWiZUewU7R0295nqyB32gvyXUq+2JTMqYqPjcPD466vc8RJlrM/ f/+1dO9Rg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljXzH-005c3R-Mu; Thu, 20 May 2021 02:00:37 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljXzA-005c38-Ky for linux-arm-kernel@desiato.infradead.org; Thu, 20 May 2021 02:00:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=U8QEKQGFiRQOQLEHv8ObhS4iuMjm72aPIoLD5Z21rRg=; b=HiDaY8WasHLkUTDiChwBLRCIdn oZc0czkPtOeKstui3GBGFqjsvFLEaXd7UvFTk3PKKQQjLRdlvOWomvKeLck7K0NGcx1/IvshijCNF jepkOB0uZ5Cw7sPJKBXCnPKDxNhpoSuhgz+SrIS+7NRqI6jNY5aBwZQSWeGS2CZx/bdJyt9Tx2SD1 NI9ynkpn43jVU9o5PpK1acxgPOauuKk5g5eT4tAjLr3y0wFVjPiDQUTYspWe+OFu+9jy86yMAcU8R LsBZ8EJA5/jE+2avmpxh6Ff3EtQWHpO93eyB1KqkYQ7RSxnbk8WdRe+1V+wMOA8xOLBgeo8tXtde1 DDDljagA==; Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljXz8-00Ft9K-7w for linux-arm-kernel@lists.infradead.org; Thu, 20 May 2021 02:00:27 +0000 Received: from [192.168.254.32] (unknown [47.187.214.213]) by linux.microsoft.com (Postfix) with ESMTPSA id 95B3A20B7178; Wed, 19 May 2021 19:00:16 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 95B3A20B7178 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1621476017; bh=U8QEKQGFiRQOQLEHv8ObhS4iuMjm72aPIoLD5Z21rRg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=NgTZCCwk+NyZJh/Q5+8WXfReGR4mxTpJnXOqpoNZOmnLZQ7bIO4nCxxUkvtVtptaF MyivxqYXEA+qoVEVQ7A43OSK60aAKmXZaGdi/NUZUwciCqMRdsGgbQCChSFczo9LPI 9cwM+2aY2NnzBKrJA1lmL9Wn/mB+rQuUCTzlJ4Y0= Subject: Re: [RFC PATCH v4 2/2] arm64: Create a list of SYM_CODE functions, blacklist them in the unwinder To: Mark Brown Cc: mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, jthierry@redhat.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org References: <68eeda61b3e9579d65698a884b26c8632025e503> <20210516040018.128105-1-madvenka@linux.microsoft.com> <20210516040018.128105-3-madvenka@linux.microsoft.com> <20210519192730.GI4224@sirena.org.uk> From: "Madhavan T. Venkataraman" Message-ID: <2067fb27-34ba-8b7e-e6ef-505796316970@linux.microsoft.com> Date: Wed, 19 May 2021 21:00:15 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210519192730.GI4224@sirena.org.uk> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210519_190026_334673_0FEF1971 X-CRM114-Status: GOOD ( 12.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thanks a lot! Madhavan On 5/19/21 2:27 PM, Mark Brown wrote: > On Sat, May 15, 2021 at 11:00:18PM -0500, madvenka@linux.microsoft.com wrote: >> From: "Madhavan T. Venkataraman" >> >> The unwinder should check if the return PC falls in any function that >> is considered unreliable from an unwinding perspective. If it does, >> mark the stack trace unreliable. > > Other than the naming issue this makes sense to me, I'll try to go > through the first patch properly in the next few days. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel