From: David Howells <dhowells@redhat.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Andrew Morton <akpm@osdl.org>, Steve Dickson <SteveD@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] VM: Fix the gfp_mask in invalidate_complete_page2
Date: Tue, 10 Oct 2006 10:43:30 +0100 [thread overview]
Message-ID: <2069.1160473410@redhat.com> (raw)
In-Reply-To: <1160170629.5453.34.camel@lade.trondhjem.org>
Trond Myklebust <Trond.Myklebust@netapp.com> wrote:
> - if (PagePrivate(page) && !try_to_release_page(page, 0))
> + if (PagePrivate(page) && !try_to_release_page(page, GFP_KERNEL))
This can't be the right way to fix things. try_to_release_page() may fail
whatever GFP flags you give it. If the page *must* be invalidated at this
point then you _must_ call the invalidatepage() op, not the releasepage() op.
What is currently there allows an instikill to take place on a page at this
point, but defers the kill on pages that are busy until all the pages have
been scanned once, thus giving I/O time to happen on busy pages whilst reaping
pages that can be made immediately available.
David
next prev parent reply other threads:[~2006-10-10 9:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 21:37 [PATCH] VM: Fix the gfp_mask in invalidate_complete_page2 Trond Myklebust
2006-10-06 21:49 ` Steve Dickson
2006-10-06 22:16 ` Trond Myklebust
2006-10-06 22:19 ` Trond Myklebust
2006-10-06 22:40 ` Andrew Morton
2006-10-06 23:09 ` Steve Dickson
2006-10-06 23:20 ` Andrew Morton
2006-10-07 2:33 ` Andrew Morton
2006-10-10 9:43 ` David Howells [this message]
2006-10-10 11:42 ` Trond Myklebust
2006-10-10 12:18 ` Steve Dickson
2006-10-10 12:27 ` Trond Myklebust
2006-10-10 13:22 ` Steve Dickson
2006-10-10 13:32 ` Trond Myklebust
2006-10-10 12:49 ` David Howells
2006-10-10 13:15 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2069.1160473410@redhat.com \
--to=dhowells@redhat.com \
--cc=SteveD@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.