From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Remy Horton <remy.horton@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] ixgbe: fix access to last byte of EEPROM
Date: Thu, 17 Sep 2015 12:13:23 +0200 [thread overview]
Message-ID: <2070411.ZdUtn3z4CD@xps13> (raw)
In-Reply-To: <1442480744-3393-1-git-send-email-remy.horton@intel.com>
2015-09-17 10:05, Remy Horton:
> Incorrect operator in ixgbe_get_eeprom & ixgbe_set_eeprom prevents
> last byte of EEPROM being read/written, and hence cannot be dumped
> or updated in entirity using these functions.
>
> Signed-off-by: Remy Horton <remy.horton@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>From my previous comment:
"
Then creating a commit starting with "fix" should trigger 2 other things:
- a Fixes: tag
- an update in the release notes (because the bug exists in previous releases)
"
Maybe it does not deserve an entry in the release notes if the bug
has no real impact.
next prev parent reply other threads:[~2015-09-17 10:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 13:07 [PATCH] ixgbe: Out-by-one in get/set EEPROM Remy Horton
2015-09-16 13:23 ` Thomas Monjalon
2015-09-17 9:05 ` [PATCH v2] ixgbe: fix access to last byte of EEPROM Remy Horton
2015-09-17 10:13 ` Thomas Monjalon [this message]
2015-09-17 13:47 ` [PATCH v3] " Remy Horton
2015-09-21 9:13 ` Ananyev, Konstantin
2015-10-28 16:15 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2070411.ZdUtn3z4CD@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.