From: Keith Owens <kaos@ocs.com.au>
To: lkml <linux-kernel@vger.kernel.org>
Subject: Re: Registering for notifier chains in modules (was Linux 2.4.21-rc3 - ipmi unresolved)
Date: Tue, 27 May 2003 15:30:43 +1000 [thread overview]
Message-ID: <20707.1054013443@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Mon, 26 May 2003 23:45:39 EST." <3ED2ED73.7090300@acm.org>
On Mon, 26 May 2003 23:45:39 -0500,
Corey Minyard <minyard@acm.org> wrote:
>Keith Owens wrote:
>>>Why can't you have a module id in the notifier chain, and use a boolean
>>>to tell if it is set, or something similar to that? That way you could
>>>mix them, if the bool is set then do the try_in_module_count thing, if
>>>not then just call the function. It does add some components to the
>>>register structure, but that shouldn't hurt anything besides taking a
>>>little more memory.
>>
>>It is a change of API in a 2.4 kernel. Not a good idea.
>>
>Does adding a field to a structure (where the user does not have to do
>anything with the
>field) change the API? That would be the only API change here.
The user does have to do something. Every piece of code that calls
notify_register has to set the new field to __THIS_MODULE. WIthout
that field being set, you are no better off, the race still exists.
next prev parent reply other threads:[~2003-05-27 5:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-22 22:19 Linux 2.4.21-rc3 Marcelo Tosatti
2003-05-22 23:46 ` J.A. Magallon
2003-05-26 17:04 ` Alan Cox
2003-05-23 0:51 ` Barry K. Nathan
2003-05-23 5:32 ` Marc-Christian Petersen
2003-05-23 7:04 ` [BUG] 2.[45] ioperm fix seems broken (was Re: Linux 2.4.21-rc3) Barry K. Nathan
2003-05-23 9:00 ` Barry K. Nathan
2003-05-23 8:27 ` Linux 2.4.21-rc3 Benjamin Herrenschmidt
2003-05-23 13:38 ` Linux 2.4.21-rc3 - ipmi unresolved Eyal Lebedinsky
2003-05-23 13:41 ` Marc-Christian Petersen
2003-05-26 2:09 ` Corey Minyard
2003-05-25 7:57 ` Keith Owens
2003-05-26 3:37 ` Corey Minyard
2003-05-26 3:54 ` Keith Owens
2003-05-27 0:30 ` Corey Minyard
2003-05-27 3:09 ` Keith Owens
2003-05-27 4:45 ` Registering for notifier chains in modules (was Linux 2.4.21-rc3 - ipmi unresolved) Corey Minyard
2003-05-27 5:30 ` Keith Owens [this message]
2003-05-27 14:48 ` Corey Minyard
2003-05-27 16:02 ` viro
2003-05-27 17:09 ` Corey Minyard
2003-05-28 0:15 ` Keith Owens
2003-05-26 17:08 ` Linux 2.4.21-rc3 - ipmi unresolved Alan Cox
2003-05-23 21:10 ` Linux 2.4.21-rc3 [net-pf-4, devfs audio, drm radeon] Gabor Z. Papp
2003-05-25 17:36 ` Linux 2.4.21-rc3 : IDE pb on Alpha Willy Tarreau
2003-05-25 17:00 ` Willy Tarreau
2003-05-25 20:37 ` Mike Fedyk
2003-05-25 20:45 ` Bartlomiej Zolnierkiewicz
2003-05-25 20:55 ` Mike Fedyk
2003-05-25 21:23 ` Bartlomiej Zolnierkiewicz
2003-05-26 7:28 ` Linux 2.4.21-rc3: doesn't build with CONFIG_BLK_DEV_HD_ONLY=y Jerome Chantelauze
2003-05-26 13:16 ` Linux 2.4.21-rc3 Santiago Garcia Mantinan
2003-05-27 1:14 ` Jeff Chua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20707.1054013443@kao2.melbourne.sgi.com \
--to=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.