From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:36460 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727013AbeINTPK (ORCPT ); Fri, 14 Sep 2018 15:15:10 -0400 From: Laurent Pinchart To: kieran.bingham+renesas@ideasonboard.com Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: rcar-du: Remove packed VYUY support Date: Fri, 14 Sep 2018 17:00:43 +0300 Message-ID: <2071986.YnXjGQr2Jv@avalon> In-Reply-To: <7d2740f2-923c-4b5d-0d1e-c24fb4a8bceb@ideasonboard.com> References: <20180914132149.26354-1-kieran.bingham+renesas@ideasonboard.com> <1759929.4apJ9N5u4E@avalon> <7d2740f2-923c-4b5d-0d1e-c24fb4a8bceb@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Kieran, On Friday, 14 September 2018 16:55:38 EEST Kieran Bingham wrote: > On 14/09/18 14:51, Laurent Pinchart wrote: > > On Friday, 14 September 2018 16:21:49 EEST Kieran Bingham wrote: > >> The Gen3 VSP used by the DU for display does not support packed the VYUY > >> pixel format. Gen2 VSP hardware is able to process this format, but it > >> is not officially supported there either and thus it's output can not be > >> guaranteed. > > > > I think we could guarantee proper operation on Gen2, but as DU + VSP > > operation isn't enabled in the drivers by default, and as the VYUY format > > isn't a strategic target, I think we can ignore that. > > > > How about updating the commit message as follows ? > > > > "The Gen3 VSP used by the DU for display does not support packed the VYUY > > s/packed the/the packed/ > > Which was a fault in my original text :) > > > pixel format. Gen2 VSP hardware is able to process this format, but DU + > > VSP operation isn't enabled on Gen2, and VYUY isn't a strategic format, > > so it can be ignored." > > That sounds fine to me, though I don't think we would even need to state > that 'VYUY isn't a strategic format' once it's simply not available on > the only platform that is enabled to use the VSP. But I don't object to > stating it otherwise. It could be enabled in the drivers (I have out-of-tree patches for testing purpose), so the fact that we don't need the format is still important I think. > >> Remove the format from the capabilities of the DU driver. > >> > >> Signed-off-by: Kieran Bingham > > > > Reviewed-by: Laurent Pinchart > > > >> --- > >> > >> drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > >> b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c index 4480243813ec..4576119e7777 > >> 100644 > >> --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > >> @@ -126,7 +126,6 @@ static const u32 formats_kms[] = { > >> DRM_FORMAT_ARGB8888, > >> DRM_FORMAT_XRGB8888, > >> DRM_FORMAT_UYVY, > >> - DRM_FORMAT_VYUY, > >> DRM_FORMAT_YUYV, > >> DRM_FORMAT_YVYU, > >> DRM_FORMAT_NV12, > >> @@ -155,7 +154,6 @@ static const u32 formats_v4l2[] = { > >> V4L2_PIX_FMT_ABGR32, > >> V4L2_PIX_FMT_XBGR32, > >> V4L2_PIX_FMT_UYVY, > >> - V4L2_PIX_FMT_VYUY, > >> V4L2_PIX_FMT_YUYV, > >> V4L2_PIX_FMT_YVYU, > >> V4L2_PIX_FMT_NV12M, -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm: rcar-du: Remove packed VYUY support Date: Fri, 14 Sep 2018 17:00:43 +0300 Message-ID: <2071986.YnXjGQr2Jv@avalon> References: <20180914132149.26354-1-kieran.bingham+renesas@ideasonboard.com> <1759929.4apJ9N5u4E@avalon> <7d2740f2-923c-4b5d-0d1e-c24fb4a8bceb@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6EEB26E8E6 for ; Fri, 14 Sep 2018 14:00:31 +0000 (UTC) In-Reply-To: <7d2740f2-923c-4b5d-0d1e-c24fb4a8bceb@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: kieran.bingham+renesas@ideasonboard.com Cc: David Airlie , linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgS2llcmFuLAoKT24gRnJpZGF5LCAxNCBTZXB0ZW1iZXIgMjAxOCAxNjo1NTozOCBFRVNUIEtp ZXJhbiBCaW5naGFtIHdyb3RlOgo+IE9uIDE0LzA5LzE4IDE0OjUxLCBMYXVyZW50IFBpbmNoYXJ0 IHdyb3RlOgo+ID4gT24gRnJpZGF5LCAxNCBTZXB0ZW1iZXIgMjAxOCAxNjoyMTo0OSBFRVNUIEtp ZXJhbiBCaW5naGFtIHdyb3RlOgo+ID4+IFRoZSBHZW4zIFZTUCB1c2VkIGJ5IHRoZSBEVSBmb3Ig ZGlzcGxheSBkb2VzIG5vdCBzdXBwb3J0IHBhY2tlZCB0aGUgVllVWQo+ID4+IHBpeGVsIGZvcm1h dC4gR2VuMiBWU1AgaGFyZHdhcmUgaXMgYWJsZSB0byBwcm9jZXNzIHRoaXMgZm9ybWF0LCBidXQg aXQKPiA+PiBpcyBub3Qgb2ZmaWNpYWxseSBzdXBwb3J0ZWQgdGhlcmUgZWl0aGVyIGFuZCB0aHVz IGl0J3Mgb3V0cHV0IGNhbiBub3QgYmUKPiA+PiBndWFyYW50ZWVkLgo+ID4gCj4gPiBJIHRoaW5r IHdlIGNvdWxkIGd1YXJhbnRlZSBwcm9wZXIgb3BlcmF0aW9uIG9uIEdlbjIsIGJ1dCBhcyBEVSAr IFZTUAo+ID4gb3BlcmF0aW9uIGlzbid0IGVuYWJsZWQgaW4gdGhlIGRyaXZlcnMgYnkgZGVmYXVs dCwgYW5kIGFzIHRoZSBWWVVZIGZvcm1hdAo+ID4gaXNuJ3QgYSBzdHJhdGVnaWMgdGFyZ2V0LCBJ IHRoaW5rIHdlIGNhbiBpZ25vcmUgdGhhdC4KPiA+IAo+ID4gSG93IGFib3V0IHVwZGF0aW5nIHRo ZSBjb21taXQgbWVzc2FnZSBhcyBmb2xsb3dzID8KPiA+IAo+ID4gIlRoZSBHZW4zIFZTUCB1c2Vk IGJ5IHRoZSBEVSBmb3IgZGlzcGxheSBkb2VzIG5vdCBzdXBwb3J0IHBhY2tlZCB0aGUgVllVWQo+ IAo+IHMvcGFja2VkIHRoZS90aGUgcGFja2VkLwo+IAo+IFdoaWNoIHdhcyBhIGZhdWx0IGluIG15 IG9yaWdpbmFsIHRleHQgOikKPiAKPiA+IHBpeGVsIGZvcm1hdC4gR2VuMiBWU1AgaGFyZHdhcmUg aXMgYWJsZSB0byBwcm9jZXNzIHRoaXMgZm9ybWF0LCBidXQgRFUgKwo+ID4gVlNQIG9wZXJhdGlv biBpc24ndCBlbmFibGVkIG9uIEdlbjIsIGFuZCBWWVVZIGlzbid0IGEgc3RyYXRlZ2ljIGZvcm1h dCwKPiA+IHNvIGl0IGNhbiBiZSBpZ25vcmVkLiIKPiAKPiBUaGF0IHNvdW5kcyBmaW5lIHRvIG1l LCB0aG91Z2ggSSBkb24ndCB0aGluayB3ZSB3b3VsZCBldmVuIG5lZWQgdG8gc3RhdGUKPiB0aGF0 ICdWWVVZIGlzbid0IGEgc3RyYXRlZ2ljIGZvcm1hdCcgb25jZSBpdCdzIHNpbXBseSBub3QgYXZh aWxhYmxlIG9uCj4gdGhlIG9ubHkgcGxhdGZvcm0gdGhhdCBpcyBlbmFibGVkIHRvIHVzZSB0aGUg VlNQLiBCdXQgSSBkb24ndCBvYmplY3QgdG8KPiBzdGF0aW5nIGl0IG90aGVyd2lzZS4KCkl0IGNv dWxkIGJlIGVuYWJsZWQgaW4gdGhlIGRyaXZlcnMgKEkgaGF2ZSBvdXQtb2YtdHJlZSBwYXRjaGVz IGZvciB0ZXN0aW5nIApwdXJwb3NlKSwgc28gdGhlIGZhY3QgdGhhdCB3ZSBkb24ndCBuZWVkIHRo ZSBmb3JtYXQgaXMgc3RpbGwgaW1wb3J0YW50IEkgCnRoaW5rLgoKPiA+PiBSZW1vdmUgdGhlIGZv cm1hdCBmcm9tIHRoZSBjYXBhYmlsaXRpZXMgb2YgdGhlIERVIGRyaXZlci4KPiA+PiAKPiA+PiBT aWduZWQtb2ZmLWJ5OiBLaWVyYW4gQmluZ2hhbSA8a2llcmFuLmJpbmdoYW0rcmVuZXNhc0BpZGVh c29uYm9hcmQuY29tPgo+ID4gCj4gPiBSZXZpZXdlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1 cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+ID4gCj4gPj4gLS0tCj4gPj4gCj4gPj4g IGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfdnNwLmMgfCAyIC0tCj4gPj4gIDEgZmls ZSBjaGFuZ2VkLCAyIGRlbGV0aW9ucygtKQo+ID4+IAo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X3ZzcC5jCj4gPj4gYi9kcml2ZXJzL2dwdS9kcm0vcmNh ci1kdS9yY2FyX2R1X3ZzcC5jIGluZGV4IDQ0ODAyNDM4MTNlYy4uNDU3NjExOWU3Nzc3Cj4gPj4g MTAwNjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV92c3AuYwo+ ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfdnNwLmMKPiA+PiBAQCAt MTI2LDcgKzEyNiw2IEBAIHN0YXRpYyBjb25zdCB1MzIgZm9ybWF0c19rbXNbXSA9IHsKPiA+PiAg CURSTV9GT1JNQVRfQVJHQjg4ODgsCj4gPj4gIAlEUk1fRk9STUFUX1hSR0I4ODg4LAo+ID4+ICAJ RFJNX0ZPUk1BVF9VWVZZLAo+ID4+IC0JRFJNX0ZPUk1BVF9WWVVZLAo+ID4+ICAJRFJNX0ZPUk1B VF9ZVVlWLAo+ID4+ICAJRFJNX0ZPUk1BVF9ZVllVLAo+ID4+ICAJRFJNX0ZPUk1BVF9OVjEyLAo+ ID4+IEBAIC0xNTUsNyArMTU0LDYgQEAgc3RhdGljIGNvbnN0IHUzMiBmb3JtYXRzX3Y0bDJbXSA9 IHsKPiA+PiAgCVY0TDJfUElYX0ZNVF9BQkdSMzIsCj4gPj4gIAlWNEwyX1BJWF9GTVRfWEJHUjMy LAo+ID4+ICAJVjRMMl9QSVhfRk1UX1VZVlksCj4gPj4gLQlWNEwyX1BJWF9GTVRfVllVWSwKPiA+ PiAgCVY0TDJfUElYX0ZNVF9ZVVlWLAo+ID4+ICAJVjRMMl9QSVhfRk1UX1lWWVUsCj4gPj4gIAlW NEwyX1BJWF9GTVRfTlYxMk0sCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==