From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Laurent Pinchart To: Sergei Shtylyov Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring Subject: Re: [PATCH v4 01/16] dt-bindings: display: renesas: Add R-Car LVDS encoder DT bindings Date: Wed, 21 Feb 2018 21:50:29 +0200 Message-ID: <2073262.MX8XBVzz43@avalon> In-Reply-To: <3ec6ef0d-1753-cf81-f619-cf43913044de@cogentembedded.com> References: <20180220231046.32638-1-laurent.pinchart+renesas@ideasonboard.com> <20180220231046.32638-2-laurent.pinchart+renesas@ideasonboard.com> <3ec6ef0d-1753-cf81-f619-cf43913044de@cogentembedded.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: devicetree-owner@vger.kernel.org List-ID: Hi Sergei, On Wednesday, 21 February 2018 10:35:13 EET Sergei Shtylyov wrote: > On 2/21/2018 2:10 AM, Laurent Pinchart wrote: > > The Renesas R-Car Gen2 and Gen3 SoCs have internal LVDS encoders. Add > > corresponding device tree bindings. > > > > Signed-off-by: Laurent Pinchart > > > > Reviewed-by: Rob Herring > > --- > > Changes since v1: > > > > - Move the SoC name before the IP name in compatible strings > > - Rename parallel input to parallel RGB input > > - Fixed "renesas,r8a7743-lvds" description > > - Document the resets property > > - Fixed typo > > --- > > > > .../bindings/display/bridge/renesas,lvds.txt | 56 ++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 57 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt> > > diff --git > > a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > > b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt new > > file mode 100644 > > index 000000000000..2b19ce51ec07 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > > @@ -0,0 +1,56 @@ > > +Renesas R-Car LVDS Encoder > > +========================== > > + > > +These DT bindings describe the LVDS encoder embedded in the Renesas R-Car > > +Gen2, R-Car Gen3 and RZ/G SoCs. > > + > > +Required properties: > > + > > +- compatible : Shall contain one of > > + - "renesas,r8a7743-lvds" for R8A7743 (RZ/G1M) compatible LVDS encoders > > + - "renesas,r8a7790-lvds" for R8A7790 (R-Car H2) compatible LVDS > > encoders > > + - "renesas,r8a7791-lvds" for R8A7791 (R-Car M2-W) compatible LVDS > > encoders + - "renesas,r8a7793-lvds" for R8A7791 (R-Car M2-N) compatible > > LVDS encoders + - "renesas,r8a7795-lvds" for R8A7795 (R-Car H3) > > compatible LVDS encoders + - "renesas,r8a7796-lvds" for R8A7796 (R-Car > > M3-W) compatible LVDS encoders + > > +- reg: Base address and length for the memory-mapped registers > > +- clocks: A phandle + clock-specifier pair for the functional clock > > +- resets: A phandle + reset specifier for the module reset > > + > > +Required nodes: > > + > > +The LVDS encoder has two video ports. Their connections are modelled > > using the +OF graph bindings specified in > > Documentation/devicetree/bindings/graph.txt. + > > +- Video port 0 corresponds to the parallel RGB input > > +- Video port 1 corresponds to the LVDS output > > + > > +Each port shall have a single endpoint. > > + > > + > > +Example: > > + > > + lvds0: lvds@feb90000 { > > "lvds-encoder@feb90000" maybe? Or just "encoder@feb90000" ? Or "display-encoder@feb90000" ? Rob, any preference ? > And do we need a # in the label if the encoder is alone in DT anyway? As a matter of fact r8a7790, on which this example is based, has two LVDS encoders. I've only included one in the example as adding a second one wouldn't have added any value. > [...] -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 01/16] dt-bindings: display: renesas: Add R-Car LVDS encoder DT bindings Date: Wed, 21 Feb 2018 21:50:29 +0200 Message-ID: <2073262.MX8XBVzz43@avalon> References: <20180220231046.32638-1-laurent.pinchart+renesas@ideasonboard.com> <20180220231046.32638-2-laurent.pinchart+renesas@ideasonboard.com> <3ec6ef0d-1753-cf81-f619-cf43913044de@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <3ec6ef0d-1753-cf81-f619-cf43913044de@cogentembedded.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sergei Shtylyov Cc: linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: devicetree@vger.kernel.org SGkgU2VyZ2VpLAoKT24gV2VkbmVzZGF5LCAyMSBGZWJydWFyeSAyMDE4IDEwOjM1OjEzIEVFVCBT ZXJnZWkgU2h0eWx5b3Ygd3JvdGU6Cj4gT24gMi8yMS8yMDE4IDI6MTAgQU0sIExhdXJlbnQgUGlu Y2hhcnQgd3JvdGU6Cj4gPiBUaGUgUmVuZXNhcyBSLUNhciBHZW4yIGFuZCBHZW4zIFNvQ3MgaGF2 ZSBpbnRlcm5hbCBMVkRTIGVuY29kZXJzLiBBZGQKPiA+IGNvcnJlc3BvbmRpbmcgZGV2aWNlIHRy ZWUgYmluZGluZ3MuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IExhdXJlbnQgUGluY2hhcnQKPiA+ IDxsYXVyZW50LnBpbmNoYXJ0K3JlbmVzYXNAaWRlYXNvbmJvYXJkLmNvbT4KPiA+IFJldmlld2Vk LWJ5OiBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwub3JnPgo+ID4gLS0tCj4gPiBDaGFuZ2VzIHNp bmNlIHYxOgo+ID4gCj4gPiAtIE1vdmUgdGhlIFNvQyBuYW1lIGJlZm9yZSB0aGUgSVAgbmFtZSBp biBjb21wYXRpYmxlIHN0cmluZ3MKPiA+IC0gUmVuYW1lIHBhcmFsbGVsIGlucHV0IHRvIHBhcmFs bGVsIFJHQiBpbnB1dAo+ID4gLSBGaXhlZCAicmVuZXNhcyxyOGE3NzQzLWx2ZHMiIGRlc2NyaXB0 aW9uCj4gPiAtIERvY3VtZW50IHRoZSByZXNldHMgcHJvcGVydHkKPiA+IC0gRml4ZWQgdHlwbwo+ ID4gLS0tCj4gPiAKPiA+ICAgLi4uL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL3JlbmVzYXMsbHZk cy50eHQgICAgICAgfCA1NiArKysrKysrKysrKysrKysrCj4gPiAgIE1BSU5UQUlORVJTICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDEgKwo+ID4gICAyIGZpbGVzIGNo YW5nZWQsIDU3IGluc2VydGlvbnMoKykKPiA+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0Cj4gPiAgIERv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS9yZW5lc2FzLGx2 ZHMudHh0PiAKPiA+IGRpZmYgLS1naXQKPiA+IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL2Rpc3BsYXkvYnJpZGdlL3JlbmVzYXMsbHZkcy50eHQKPiA+IGIvRG9jdW1lbnRhdGlv bi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL3JlbmVzYXMsbHZkcy50eHQgbmV3 Cj4gPiBmaWxlIG1vZGUgMTAwNjQ0Cj4gPiBpbmRleCAwMDAwMDAwMDAwMDAuLjJiMTljZTUxZWMw Nwo+ID4gLS0tIC9kZXYvbnVsbAo+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL2Rpc3BsYXkvYnJpZGdlL3JlbmVzYXMsbHZkcy50eHQKPiA+IEBAIC0wLDAgKzEsNTYg QEAKPiA+ICtSZW5lc2FzIFItQ2FyIExWRFMgRW5jb2Rlcgo+ID4gKz09PT09PT09PT09PT09PT09 PT09PT09PT09Cj4gPiArCj4gPiArVGhlc2UgRFQgYmluZGluZ3MgZGVzY3JpYmUgdGhlIExWRFMg ZW5jb2RlciBlbWJlZGRlZCBpbiB0aGUgUmVuZXNhcyBSLUNhcgo+ID4gK0dlbjIsIFItQ2FyIEdl bjMgYW5kIFJaL0cgU29Dcy4KPiA+ICsKPiA+ICtSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ID4gKwo+ ID4gKy0gY29tcGF0aWJsZSA6IFNoYWxsIGNvbnRhaW4gb25lIG9mCj4gPiArICAtICJyZW5lc2Fz LHI4YTc3NDMtbHZkcyIgZm9yIFI4QTc3NDMgKFJaL0cxTSkgY29tcGF0aWJsZSBMVkRTIGVuY29k ZXJzCj4gPiArICAtICJyZW5lc2FzLHI4YTc3OTAtbHZkcyIgZm9yIFI4QTc3OTAgKFItQ2FyIEgy KSBjb21wYXRpYmxlIExWRFMKPiA+IGVuY29kZXJzCj4gPiArICAtICJyZW5lc2FzLHI4YTc3OTEt bHZkcyIgZm9yIFI4QTc3OTEgKFItQ2FyIE0yLVcpIGNvbXBhdGlibGUgTFZEUwo+ID4gZW5jb2Rl cnMgKyAgLSAicmVuZXNhcyxyOGE3NzkzLWx2ZHMiIGZvciBSOEE3NzkxIChSLUNhciBNMi1OKSBj b21wYXRpYmxlCj4gPiBMVkRTIGVuY29kZXJzICsgIC0gInJlbmVzYXMscjhhNzc5NS1sdmRzIiBm b3IgUjhBNzc5NSAoUi1DYXIgSDMpCj4gPiBjb21wYXRpYmxlIExWRFMgZW5jb2RlcnMgKyAgLSAi cmVuZXNhcyxyOGE3Nzk2LWx2ZHMiIGZvciBSOEE3Nzk2IChSLUNhcgo+ID4gTTMtVykgY29tcGF0 aWJsZSBMVkRTIGVuY29kZXJzICsKPiA+ICstIHJlZzogQmFzZSBhZGRyZXNzIGFuZCBsZW5ndGgg Zm9yIHRoZSBtZW1vcnktbWFwcGVkIHJlZ2lzdGVycwo+ID4gKy0gY2xvY2tzOiBBIHBoYW5kbGUg KyBjbG9jay1zcGVjaWZpZXIgcGFpciBmb3IgdGhlIGZ1bmN0aW9uYWwgY2xvY2sKPiA+ICstIHJl c2V0czogQSBwaGFuZGxlICsgcmVzZXQgc3BlY2lmaWVyIGZvciB0aGUgbW9kdWxlIHJlc2V0Cj4g PiArCj4gPiArUmVxdWlyZWQgbm9kZXM6Cj4gPiArCj4gPiArVGhlIExWRFMgZW5jb2RlciBoYXMg dHdvIHZpZGVvIHBvcnRzLiBUaGVpciBjb25uZWN0aW9ucyBhcmUgbW9kZWxsZWQKPiA+IHVzaW5n IHRoZSArT0YgZ3JhcGggYmluZGluZ3Mgc3BlY2lmaWVkIGluCj4gPiBEb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvZ3JhcGgudHh0LiArCj4gPiArLSBWaWRlbyBwb3J0IDAgY29ycmVz cG9uZHMgdG8gdGhlIHBhcmFsbGVsIFJHQiBpbnB1dAo+ID4gKy0gVmlkZW8gcG9ydCAxIGNvcnJl c3BvbmRzIHRvIHRoZSBMVkRTIG91dHB1dAo+ID4gKwo+ID4gK0VhY2ggcG9ydCBzaGFsbCBoYXZl IGEgc2luZ2xlIGVuZHBvaW50Lgo+ID4gKwo+ID4gKwo+ID4gK0V4YW1wbGU6Cj4gPiArCj4gPiAr CWx2ZHMwOiBsdmRzQGZlYjkwMDAwIHsKPiAKPiAibHZkcy1lbmNvZGVyQGZlYjkwMDAwIiBtYXli ZT8KCk9yIGp1c3QgImVuY29kZXJAZmViOTAwMDAiID8gT3IgImRpc3BsYXktZW5jb2RlckBmZWI5 MDAwMCIgPyBSb2IsIGFueSAKcHJlZmVyZW5jZSA/Cgo+IEFuZCBkbyB3ZSBuZWVkIGEgIyBpbiB0 aGUgbGFiZWwgaWYgdGhlIGVuY29kZXIgaXMgYWxvbmUgaW4gRFQgYW55d2F5PwoKQXMgYSBtYXR0 ZXIgb2YgZmFjdCByOGE3NzkwLCBvbiB3aGljaCB0aGlzIGV4YW1wbGUgaXMgYmFzZWQsIGhhcyB0 d28gTFZEUyAKZW5jb2RlcnMuIEkndmUgb25seSBpbmNsdWRlZCBvbmUgaW4gdGhlIGV4YW1wbGUg YXMgYWRkaW5nIGEgc2Vjb25kIG9uZSAKd291bGRuJ3QgaGF2ZSBhZGRlZCBhbnkgdmFsdWUuCgo+ IFsuLi5dCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=