RE: [Qemu-devel] [6336] DisplayState interface change (StefanoStabellini)

[laurent@lvivier.info]

>Revision: 6336
>          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6336
>Author:   aliguori
>Date:     2009-01-15 22:14:11 +0000 (Thu, 15 Jan 2009)
>
>Log Message:
>-----------
>DisplayState interface change (Stefano Stabellini)

This patch breaks qemu-system-ppc:

in update_palette256(), s->rgb_to_pixel() is used unitialized.

update_palette256() is called by vga_draw_graphic() whereas s->rgb_to_pixel() is initialized later in the function.

This patch correct the problem.

Signed-off-by: Laurent Vivier <Laurent@lvivier.info>

diff --git a/hw/vga.c b/hw/vga.c
index f2d98b0..769faea 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -1838,6 +1838,7 @@ static void vga_update_display(void *opaque)
             s->graphic_mode = graphic_mode;
             full_update = 1;
         }
+        s->rgb_to_pixel = rgb_to_pixel_dup_table[get_depth_index(s->ds)];
         switch(graphic_mode) {
         case GMODE_TEXT:
             vga_draw_text(s, full_update);