Re: [PATCH v3 01/22] wifi: rtw88: Add some definitions for RTL8821AU/RTL8812AU

[Bitterblue Smith <rtl8821cerfe2@gmail.com>]

On 29/10/2024 06:22, Ping-Ke Shih wrote:
> Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> 
>> Add 8821A and 8812A chip type enums.
>>
>> Add cck_high_power member to struct rtw_hal. This will be used to
>> calculate the RX signal strength of RTL8812AU.
>>
>> Add various register definitions which will be used by the new drivers.
>>
>> Move some existing register definitions from rtw8821c.h and rtw8822b.h.
>> They were duplicated in those headers and will also be used by the new
>> drivers.
>>
>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> 
> Smatch warns
> 
>   drivers/net/wireless/realtek/rtw88/rtw8812a.c:619 rtw8812a_iqk() error: uninitialized symbol 'tx_x1'.
>   drivers/net/wireless/realtek/rtw88/rtw8812a.c:621 rtw8812a_iqk() error: uninitialized symbol 'tx_y1'.
> 

These are false positives. The variables are initialised inside
rtw88xxa_iqk_finish(). But I'll initialise them when they are
declared.

> Please respin patches 16-22.
> 
> 15 patch(es) applied to rtw-next branch of rtw.git, thanks.
> 
> d12722830ea4 wifi: rtw88: Add some definitions for RTL8821AU/RTL8812AU
> 87341ca1eac9 wifi: rtw88: Dump the HW features only for some chips
> d9018f437351 wifi: rtw88: Allow different C2H RA report sizes
> 95a772e30b60 wifi: rtw88: Extend the init table parsing for RTL8812AU
> 7c5bbeba7c36 wifi: rtw88: Allow rtw_chip_info.ltecoex_addr to be NULL
> fbb5e1b3637a wifi: rtw88: Let each driver control the power on/off process
> c7706b1173c7 wifi: rtw88: Enable data rate fallback for older chips
> abb0f19492ba wifi: rtw88: Make txagc_remnant_ofdm an array
> 82a617413e85 wifi: rtw88: Support TX page sizes bigger than 128
> 67d915604e69 wifi: rtw88: Move pwr_track_tbl to struct rtw_rfe_def
> 85bf3041a0ea wifi: rtw88: usb: Set pkt_info.ls for the reserved page
> 57289d30cd2a wifi: rtw88: Detect beacon loss with chips other than 8822c
> b19840afc051 wifi: rtw88: coex: Support chips without a scoreboard
> bfcee5ee924f wifi: rtw88: 8821a: Regularly ask for BT info updates
> f9e0189cbc2d wifi: rtw88: 8812a: Mitigate beacon loss
> 
> ---
> https://github.com/pkshih/rtw.git
>