From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: remove skinny extent verbose message
Date: Thu, 23 Jun 2022 17:52:50 +0800 [thread overview]
Message-ID: <207c3f84-7a6c-bc61-d8ca-083ee29fa8ba@gmx.com> (raw)
In-Reply-To: <20220623080858.1433010-1-nborisov@suse.com>
On 2022/6/23 16:08, Nikolay Borisov wrote:
> Skinny extents have been a default mkfs feature since version 3.18 i
> (introduced in btrfs-progs commit 6715de04d9a7 ("btrfs-progs: mkfs:
> make skinny-metadata default") ). It really doesn't bring any value to
> users to simply remove it.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
> fs/btrfs/disk-io.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index 8c34d08e3c64..0af4c03279df 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -3501,9 +3501,6 @@ int __cold open_ctree(struct super_block *sb, struct btrfs_fs_devices *fs_device
> else if (fs_info->compress_type == BTRFS_COMPRESS_ZSTD)
> features |= BTRFS_FEATURE_INCOMPAT_COMPRESS_ZSTD;
>
> - if (features & BTRFS_FEATURE_INCOMPAT_SKINNY_METADATA)
> - btrfs_info(fs_info, "has skinny extents");
> -
> /*
> * Flag our filesystem as having big metadata blocks if they are bigger
> * than the page size.
next prev parent reply other threads:[~2022-06-23 9:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 8:08 [PATCH] btrfs: remove skinny extent verbose message Nikolay Borisov
2022-06-23 8:22 ` Qu Wenruo
2022-06-23 8:30 ` Nikolay Borisov
2022-06-23 14:19 ` David Sterba
2022-06-23 22:46 ` Criteria for mount messages. (was "Re: [PATCH] btrfs: remove skinny extent verbose message") Qu Wenruo
2022-06-24 9:10 ` Forza
2022-06-24 10:52 ` Martin Steigerwald
2022-06-24 13:10 ` Forza
2022-06-23 9:30 ` [PATCH] btrfs: remove skinny extent verbose message Nikolay Borisov
2022-06-23 9:52 ` Qu Wenruo [this message]
2022-06-24 16:21 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=207c3f84-7a6c-bc61-d8ca-083ee29fa8ba@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.