All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, "Tan, Jianfeng" <jianfeng.tan@intel.com>
Subject: Re: [PATCH 1/2] eal/ipc: fix use-after-free in synchronous requests
Date: Tue, 17 Apr 2018 01:19:35 +0200	[thread overview]
Message-ID: <2082606.hxpljrm1bS@xps> (raw)
In-Reply-To: <e7be6224-df9d-1715-6d4c-a40c630fac4a@intel.com>

13/04/2018 17:33, Tan, Jianfeng:
> 
> On 4/13/2018 7:54 PM, Anatoly Burakov wrote:
> > Previously, we were adding synchronous requests to request list, we
> > were doing it after checking if request existed. However, we only
> > removed the request from the request list if we have succeeded in
> > sending the request. In case of failed request send, we left an
> > invalid pointer in the request list.
> >
> > Fix this by only adding request to the list once we succeed in
> > sending it.
> >
> > Fixes: 783b6e54971d ("eal: add synchronous multi-process communication")
> > Cc: jianfeng.tan@intel.com
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> Nice catch.
> 
> Acked-by: Jianfeng Tan <jianfeng.tan@intel.com>

Series applied, thanks

      reply	other threads:[~2018-04-16 23:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-13 11:54 [PATCH 1/2] eal/ipc: fix use-after-free in synchronous requests Anatoly Burakov
2018-04-13 11:55 ` [PATCH 2/2] eal/ipc: fix use-after-free in asynchronous requests Anatoly Burakov
2018-04-13 15:34   ` Tan, Jianfeng
2018-04-13 15:33 ` [PATCH 1/2] eal/ipc: fix use-after-free in synchronous requests Tan, Jianfeng
2018-04-16 23:19   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2082606.hxpljrm1bS@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.