From: Thomas Monjalon <thomas@monjalon.net>
To: ferruh.yigit@intel.com
Cc: dev@dpdk.org, Jie Pan <panjie5@jd.com>
Subject: Re: [dpdk-dev] [PATCH] lib/librte_kni: fix the type for mac address
Date: Fri, 05 Apr 2019 01:27:35 +0200 [thread overview]
Message-ID: <2083070.Rv04mBFgE6@xps> (raw)
In-Reply-To: <1548301983-20020-1-git-send-email-panjie5@jd.com>
24/01/2019 04:53, Jie Pan:
> The type for mac address in struct rte_kni_conf should be unsigned.
>
> Signed-off-by: Jie Pan <panjie5@jd.com>
> ---
> lib/librte_kni/rte_kni.h | 2 +-
> - char mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
> + uint8_t mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
Ferruh, it seems this patch is lacking a review.
next prev parent reply other threads:[~2019-04-04 23:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 3:53 [PATCH] lib/librte_kni: fix the type for mac address Jie Pan
2019-04-04 23:27 ` Thomas Monjalon [this message]
2019-04-09 19:47 ` [dpdk-dev] " Yigit, Ferruh
2019-04-10 6:20 ` [dpdk-dev] 答复: " 潘杰
2019-04-10 6:09 ` [dpdk-dev] [PATCH v2] kni: fix the type for MAC address Jie Pan
2019-04-10 6:20 ` Jie Pan
2019-04-19 12:15 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-04-19 15:29 ` Rami Rosen
2019-04-19 20:58 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2083070.Rv04mBFgE6@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=panjie5@jd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.