From: Thomas Monjalon <thomas@monjalon.net>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Cc: dev@dpdk.org, Don Provan <dprovan@bivio.net>,
Jan Blunck <jblunck@infradead.org>,
Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCH] eal: bus scan and probe never fail
Date: Thu, 12 Oct 2017 00:32:25 +0200 [thread overview]
Message-ID: <2083909.jE3c2aJxlO@xps> (raw)
In-Reply-To: <BY1PR01MB1386DB598A380C471E618FDEA04A0@BY1PR01MB1386.prod.exchangelabs.com>
11/10/2017 02:03, Don Provan:
> From: Shreyansh Jain [mailto:shreyansh.jain@nxp.com]
> >
> > ...
> >
> > > From the application's point of view, the potential error here
> > > is that the device it wants to use isn't available. I don't see that
> > > either the init function or the probe function will have enough
> > > information to understand that application-level problem, so
> > > they should leave it to the application to detect it.
> >
> > I think I understand you comment but just want to cross check again:
> > Scan or probe error should simply be ignored by EAL layer and let the
> > application take stance when it detects that the device it was looking
> > for is missing. Is my understanding correct?
> >
> > I am trying to come a conclusion so that this patch can either be
> > modified or pushed as it is. If the above understanding is correct, I
> > don't see any changes required in the patch.
>
> Yes, I agree my comments support the patch as is.
> -don
Applied, thanks for the discussion
prev parent reply other threads:[~2017-10-11 22:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-12 10:22 [PATCH] eal: bus scan and probe never fail Shreyansh Jain
2017-09-18 11:36 ` Hemant Agrawal
2017-09-19 18:51 ` Jan Blunck
2017-10-05 23:21 ` Thomas Monjalon
2017-10-06 13:12 ` Shreyansh Jain
2017-10-06 13:37 ` Thomas Monjalon
2017-10-06 17:34 ` Jan Blunck
2017-10-09 11:10 ` Shreyansh Jain
2017-10-09 18:21 ` Don Provan
2017-10-09 19:34 ` Thomas Monjalon
2017-10-10 5:00 ` Shreyansh Jain
2017-10-10 16:00 ` Aaron Conole
2017-10-11 22:34 ` Thomas Monjalon
2017-10-12 13:08 ` Aaron Conole
2017-10-12 5:39 ` Shreyansh Jain
2017-10-12 13:20 ` Aaron Conole
2017-10-12 14:23 ` Shreyansh Jain
2017-10-11 0:03 ` Don Provan
2017-10-11 22:32 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2083909.jE3c2aJxlO@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=dprovan@bivio.net \
--cc=hemant.agrawal@nxp.com \
--cc=jblunck@infradead.org \
--cc=shreyansh.jain@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.