From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH] ARM: rockchip: disable dapswjdp during suspend Date: Sat, 25 Apr 2015 02:14:58 +0200 Message-ID: <2083913.tsdTRJp6Sn@diego> References: <1429077431-31326-1-git-send-email-zyw@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1429077431-31326-1-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Chris Zhong Cc: Russell King , dtor-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, sonnyrao-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rockchip.vger.kernel.org Am Mittwoch, 15. April 2015, 13:57:11 schrieb Chris Zhong: > Reset dapswjdp is controlled by JTAG_TRSTN, if the iomux of this pin is > not "jtag_trstn". the AP would think this pin is always high, so it can > not reset before resume. When system resume, but the dapswjdp is not in > a default state, it may Access some illegal address, it cause system > crash during resume. > Let's disable this jtag function by clear the dapdeviceen bit, it > prohibit the dapswjdp to access memory and registers. This bit would > be enable in MASKROM, so we need clear it in suspend everytime. > > Signed-off-by: Chris Zhong applied to a fixes branch for 4.1 Thanks Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?ISO-8859-1?Q?St=FCbner?=) Date: Sat, 25 Apr 2015 02:14:58 +0200 Subject: [PATCH] ARM: rockchip: disable dapswjdp during suspend In-Reply-To: <1429077431-31326-1-git-send-email-zyw@rock-chips.com> References: <1429077431-31326-1-git-send-email-zyw@rock-chips.com> Message-ID: <2083913.tsdTRJp6Sn@diego> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Mittwoch, 15. April 2015, 13:57:11 schrieb Chris Zhong: > Reset dapswjdp is controlled by JTAG_TRSTN, if the iomux of this pin is > not "jtag_trstn". the AP would think this pin is always high, so it can > not reset before resume. When system resume, but the dapswjdp is not in > a default state, it may Access some illegal address, it cause system > crash during resume. > Let's disable this jtag function by clear the dapdeviceen bit, it > prohibit the dapswjdp to access memory and registers. This bit would > be enable in MASKROM, so we need clear it in suspend everytime. > > Signed-off-by: Chris Zhong applied to a fixes branch for 4.1 Thanks Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030955AbbDYAPK (ORCPT ); Fri, 24 Apr 2015 20:15:10 -0400 Received: from gloria.sntech.de ([95.129.55.99]:59693 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752658AbbDYAPH (ORCPT ); Fri, 24 Apr 2015 20:15:07 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Chris Zhong Cc: dianders@chromium.org, dtor@chromium.org, sonnyrao@chromium.org, linux-rockchip@lists.infradead.org, Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: rockchip: disable dapswjdp during suspend Date: Sat, 25 Apr 2015 02:14:58 +0200 Message-ID: <2083913.tsdTRJp6Sn@diego> User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1429077431-31326-1-git-send-email-zyw@rock-chips.com> References: <1429077431-31326-1-git-send-email-zyw@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 15. April 2015, 13:57:11 schrieb Chris Zhong: > Reset dapswjdp is controlled by JTAG_TRSTN, if the iomux of this pin is > not "jtag_trstn". the AP would think this pin is always high, so it can > not reset before resume. When system resume, but the dapswjdp is not in > a default state, it may Access some illegal address, it cause system > crash during resume. > Let's disable this jtag function by clear the dapdeviceen bit, it > prohibit the dapswjdp to access memory and registers. This bit would > be enable in MASKROM, so we need clear it in suspend everytime. > > Signed-off-by: Chris Zhong applied to a fixes branch for 4.1 Thanks Heiko