From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41262)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bmpKf-0002yX-1X
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 17:45:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bmpKZ-0000y7-UP
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 17:45:31 -0400
Received: from mx3-phx2.redhat.com ([209.132.183.24]:41034)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bmpKZ-0000xm-Ka
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 17:45:27 -0400
Date: Wed, 21 Sep 2016 17:44:45 -0400 (EDT)
From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <mlureau@redhat.com>
Message-ID: <208403532.544963.1474494285084.JavaMail.zimbra@redhat.com>
In-Reply-To: <0930de91-13c5-d560-73f8-2a3623204006@redhat.com>
References: <20160921201018.20957-1-marcandre.lureau@redhat.com>
	<20160921201018.20957-5-marcandre.lureau@redhat.com>
	<0930de91-13c5-d560-73f8-2a3623204006@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 4/4] iotests: fix expected error message
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org, berto@igalia.com, armbru@redhat.com



----- Original Message -----
> On 09/21/2016 03:10 PM, Marc-Andr=C3=A9 Lureau wrote:
> > Missing argument returns a corresponding error message for all types
> > now.
> >=20
> > The "old" qmp dispatch code didn't return QERR_MISSING_PARAMETER for
> > argument structure members (it returned QERR_INVALID_PARAMETER). Only
> > for top-level argument it did return QERR_MISSING_PARAMETER. It is
> > preferable to have a consistent error for missing fields in inner
> > structs as well.
> >=20
> > Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
> > Reviewed-by: Alberto Garcia <berto@igalia.com>
> > ---
> >  tests/qemu-iotests/087.out | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> Yes, this looks better.
>=20
> If the message is changed earlier in this series, then this should be
> squashed into that patch (3/4?); if the message changed as the result of
> an earlier commit, the commit message should call out the id at which
> the tree was temporarily broken.

I checked, it's the previous patch that introduce the change (I wasn't sure=
 given that in alternate case qapi already returned MISSING_PARAMETER), it =
can be squashed with it.