From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Jingjing Wu <jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v2 0/2] new filter APIs definition
Date: Tue, 21 Oct 2014 00:04:40 +0200 [thread overview]
Message-ID: <2085898.nAXrvty0kN@xps13> (raw)
In-Reply-To: <1413783633-16222-1-git-send-email-jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-20 13:40, Jingjing Wu:
> new filter APIs definition in ethdev
> define filter_ctrl ops in i40e driver
>
> v2 changes:
> remove OP from the name of filter opeartions
> add API implementation in i40e.
> correct comments
>
> Jingjing Wu (2):
> librte_ether: new filter APIs definition
> i40e: define filter_ctrl ops in i40e driver
As Bruce suggested, RTE_ETH_FILTER_NOP is simpler than RTE_ETH_FILTER_OP_NONE.
And I think RTE_ETH_FILTER_GET_INFO could be RTE_ETH_FILTER_INFO.
Last comment: filtering features (fdir, hash) should not be defined at this stage.
I know that we want this patch integrated with high priority, so I made the above
changes by myself. Hope you'll agree.
Acked-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Applied
Thank you for your patience
--
Thomas
prev parent reply other threads:[~2014-10-20 22:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 23:29 [PATCH] lib/librte_ether: new filter APIs definition Jingjing Wu
[not found] ` <1413502161-31403-1-git-send-email-jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-17 1:16 ` Zhang, Helin
2014-10-17 9:07 ` Thomas Monjalon
2014-10-17 9:17 ` Richardson, Bruce
2014-10-17 16:01 ` Wu, Jingjing
[not found] ` <9BB6961774997848B5B42BEC655768F8B104C0-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-10-20 3:38 ` Wu, Jingjing
2014-10-20 1:09 ` Liu, Jijiang
2014-10-20 5:40 ` [PATCH v2 0/2] " Jingjing Wu
[not found] ` <1413783633-16222-1-git-send-email-jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-20 5:40 ` [PATCH v2 1/2] librte_ether: " Jingjing Wu
2014-10-20 5:40 ` [PATCH v2 2/2] i40e: define filter_ctrl ops in i40e driver Jingjing Wu
2014-10-20 22:04 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2085898.nAXrvty0kN@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.