From: Christian Lamparter <chunkeey@googlemail.com>
To: Oleksij Rempel <linux@rempel-privat.de>
Cc: linux-wireless@vger.kernel.org
Subject: Re: correct way to reduce traffic needed for LED triggering
Date: Wed, 11 Sep 2013 21:00:05 +0200 [thread overview]
Message-ID: <2087752.rTT3R1h3WM@debian64> (raw)
In-Reply-To: <5230B721.40104@rempel-privat.de>
On Wednesday 11 September 2013 20:32:01 Oleksij Rempel wrote:
> what is correct way to reduce IO needed for LED blinking? I did it with
> ieee80211_queue_delayed_work(.., &priv->led-work, msecs_to_jiffird(HZ));
>
> or are there other way to regulate it?
Yes, you can offload some "blinking" overhead by implementing
blink_set in led_classdev (aka "priv->led_cdev").
<http://lxr.free-electrons.com/source/include/linux/leds.h#L61>
(Of course, you'll have to add the "blink" routines into
the FW. But that shouldn't be much of a problem).
If you need some inspiration: rt2x00, iwlegacy and iwlwifi
are using blink_set.
Regards,
Christian
prev parent reply other threads:[~2013-09-11 19:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 18:32 correct way to reduce traffic needed for LED triggering Oleksij Rempel
2013-09-11 19:00 ` Christian Lamparter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2087752.rTT3R1h3WM@debian64 \
--to=chunkeey@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@rempel-privat.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.