From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Xie, Huawei" <huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] lib/librte_vhost: code style fixes
Date: Wed, 05 Nov 2014 22:25:17 +0100 [thread overview]
Message-ID: <2088055.shkfIhmk6J@xps13> (raw)
In-Reply-To: <C37D651A908B024F974696C65296B57B0F2E23EB-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-05 21:21, Xie, Huawei:
> Thomas:
> I checked before. checkpatch reports 9 warnings, "over 80 characters" and "prefer pr_deubg".
> This code style fixes code style issue only, not the pr_debug/printk issue. Thoughts?
Using pr_debug is a code style fix.
> Besides, I don't understand the MISORDERED_TYPE.
You should replace (long long unsigned) by (unsigned long long).
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> > Sent: Wednesday, November 05, 2014 1:42 PM
> > To: Xie, Huawei
> > Cc: dev-VfR2kkLFssw@public.gmane.org
> > Subject: Re: [dpdk-dev] [PATCH] lib/librte_vhost: code style fixes
> >
> > Hi Huawei,
> >
> > checkpatch.pl reports some errors of types PREFER_PR_LEVEL
> > and MISORDERED_TYPE.
> >
> > --
> > Thomas
next prev parent reply other threads:[~2014-11-05 21:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 17:03 [PATCH] lib/librte_vhost: code style fixes Huawei Xie
[not found] ` <1415206995-1086-1-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-05 20:41 ` Thomas Monjalon
2014-11-05 21:21 ` Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F2E23EB-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-05 21:25 ` Thomas Monjalon [this message]
2014-11-05 21:55 ` Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F2E2498-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-05 22:06 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2014-11-05 4:42 Huawei Xie
[not found] ` <1415162572-25941-1-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-05 9:09 ` Thomas Monjalon
2014-11-05 17:07 ` Xie, Huawei
2014-11-05 4:40 Huawei Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2088055.shkfIhmk6J@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.