From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pSDVG-0007rL-Jz for mharc-grub-devel@gnu.org; Wed, 15 Feb 2023 03:51:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSDVE-0007r1-Cc for grub-devel@gnu.org; Wed, 15 Feb 2023 03:51:00 -0500 Received: from mout.gmx.net ([212.227.15.15]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSDVC-0007Zh-LJ for grub-devel@gnu.org; Wed, 15 Feb 2023 03:51:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1676451056; bh=rnJ2LSl7DMvgSkqdpqgpBtcH1pFTlN9/jSYJu/obctM=; h=X-UI-Sender-Class:Date:From:To:Subject:References:In-Reply-To; b=arPHJSm5NuuV1S8WvyL0848IbqiAbRmMmrV4eUbYY5sA3Ne2BhEYP3gnozfalwxY/ sQYlsioEVtEsS0Nn7SGieCgZ5t+5ADL96i/27ek0xLS4iQTumdqTrmY4KuIawWtjlm 5CRfF1Dm2DirsM6nXNdLs3VIdnSK57oTw1XgnPcAnohLUse72HzcG65gI1Bak2oFLb EPWZXcYfOxD89BgK62dX5IsZ480rEeoaVm03P6pz2tlWZ0Oj1qO+fqFktXDNLrH8WB BEGByiiYi5r8WyqXe58lVHL9Qkh7T0GCLUeYjkymeA1j4ZSSNgsDatdfWNkQbKjZZ+ v8rKJCkX1vNfw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from scdbackup.webframe.org ([84.179.243.254]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N8ofE-1oWPqA2WZC-015oPD for ; Wed, 15 Feb 2023 09:50:56 +0100 Date: Wed, 15 Feb 2023 09:51:18 +0100 From: "Thomas Schmitt" To: grub-devel@gnu.org Subject: Re: make check: grub-mkrescue fails missing unicode.pf2. Leftovers in /tmp Content-Type: text/plain; charset="utf-8" References: <20230214110050.7c9a0f93@crass-HP-ZBook-15-G2> In-Reply-To: <20230214110050.7c9a0f93@crass-HP-ZBook-15-G2> Message-Id: <20883390706746626444@scdbackup.webframe.org> X-Provags-ID: V03:K1:fujjp+GS+UmmNISf2i7nVB/Z2gTO7wYxbwTGjyLhXzDeeYR0f7G 77rEf+xb7acyI8WdOxX3FBziBWACjsJSq5jUrjox7B5o89ek72wQDkKVzQkV7CqJ5XuRZqa 4XVxinGhe5l0mzC42wgrzI4FGGG2qV8TRy8kCkYO3LiyKpBt+kvll8O0R/l0q1cCYf7sffm 9IxKnsvc7gukaAFnZ464g== UI-OutboundReport: notjunk:1;M01:P0:2z+OhqsHojY=;AhO6SQ3Hs6BTH0C9XW+rgDZy3k0 DDoOoumIwTdDLAVz7ZekgCXcPeoRGbP6nwjUnY8Y67EQA7pWHRrNeQGJjOMC1AJLgD1ZLNyge bdRkz4aj/drTCmXvSuc0NOTl0vxey3Mxf861XSrtXIZgFLLZF7wl3DPhccJlmIjHIcUO4c+nZ feOIpkhjdaJklsdHh5Cen2fJVohx5JYXqTsCYTHWVNCCfRi0PmeuopyiWOt3Ll/RaAv2OhS6D r+ccF7/5RqllouwexZM8SrGCEmOu405ZeLnZ1coLCpi+Tfnxw4q9Gaqs9yoKWre3H4aiVlBL2 W8BrXsnZhbjuDklow48RqY7iTbdgP2NERV3qiiAezXXCRob231Bz6RH9HrSBJm5wzMiEix1VX yrWxr0bqNOHdHN3abVAyJw/+r0TmyDYNvCZVsIZEvAo4mRhAQgmJcKIcE94v2isMCYDwkLh5L nE8Jc7rg7jUKv1u88S3LaDb8BGi3JPNUyhwqstCdOW+Kobo9BsAHONFuQaR7dfMaaDC6dojA8 cWMX7REiHXihPB7uMguLcRpltWV1jRoXgq+INUgq08B8JdwGGBtDyiV+JlLgSp543FxahiufY 9ou1NSxuzMQmPLEMlP2z0vg/ZNklLacEKndKc9AdnytinqpbHZD5GPW/LeUe9O4S8Jrc4Ih+Z 0a38mF8I2y6yOOA+X2n18Rd0cgcMBs0KTy0zadlwsBX8SFNUMXbZuTt2tJyFBGbJAm/0UUYDL /ZsbOnZ9zlqp+GIHNnP3kvOW6Ufvil0E/oh90+i/ia3PhGp5qUJpt73vPbpZ5Hkic0IaGPLXx 0EtHTQcAm1S3dH+g4dbaBK43zg5LLJGR5XJHV0DBpPi1JrDN5jsbWDAUa/fjmRajFTeAcsk6g oy6d56x6zk0qO7JjkakUXx7tNoNR9lAKzsbYlB4WMJsQ1Z5ycXvpZZduQa828zk+755gmyZRo bxc76OWrx/z0FThMUQv7OqEaS2o= Received-SPF: pass client-ip=212.227.15.15; envelope-from=scdbackup@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Feb 2023 08:51:00 -0000 Hi, Glenn Washburn wrote: > IIRC, xfonts-unifont is pulled in by the unifont package on Debian, but > it is the one with the files you need. No, its not documented, but then > not every single debian package name needed is documented because the > documentation is partially distribution agnostic. If it were documented > it would be in ./INSTALL, which does talk about needing unifonts. If > you'd like to modify that file to help other Debian users, I'm > supportive. Unicode is mentioned two times in INSTALL. Once for building "GRUB's graphical terminal (gfxterm)", once as "Platform-agnostic tools and data". There is also a section "Debian named packages required mostly for the full suite of filesystem testing" which could host the name of the needed package. Although it is not about filesystems the mentioning could be justified by the word "mostly" in the headline. Or it could be mentioned as own point one level higher under "Prerequisites for make-check". But actually the lack of unifont did not hamper building GRUB from git. So i would expect that this tolerance is somewhat reflected by the tests. How about putting in tests/grub_func_test.in a test for the existence of /boot/grub/fonts/unicode.pf2 with an informative error message if it is missing ? Since we know that xorriso under grub-mkrescue will cause early failure if the file is missing, there is no use in running grub-shell with the demand for unicode.pf2. I see that grub_func_test.in already has provisions to declare "Functional test failure". Maybe the new code path could join that. Or it could be declared as skipped. (I still have to find out how to cause a SKIP message in the test log.) Have a nice day :) Thomas