From: David Howells <dhowells@redhat.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch 2.6.19-rc2] Correct definition of handle_IPI
Date: Wed, 18 Oct 2006 10:10:57 +0000 [thread overview]
Message-ID: <20900.1161166257@redhat.com> (raw)
In-Reply-To: <8916.1161149809@kao2.melbourne.sgi.com>
Keith Owens <kaos@sgi.com> wrote:
> The declaration of handle_IPI should really be in a header file instead
> of a .c file, but which one? Adding
>
> extern irqreturn_t handle_IPI(int irq, void *dev_id);
Stick it in arch/ia64/kernel/internal.h. That way it'll not be directly
exposed to the rest of the kernel. Then #include that file from interested
parties in that directory.
Otherwise your patch looks reasonable.
Acked-By: David Howells <dhowells@redhat.com>
prev parent reply other threads:[~2006-10-18 10:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-18 5:36 [patch 2.6.19-rc2] Correct definition of handle_IPI Keith Owens
2006-10-18 10:10 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20900.1161166257@redhat.com \
--to=dhowells@redhat.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.