Re: [dpdk-dev] [dpdk-techboard] [PATCH v2] vhost: mark vDPA driver API as internal

[Thomas Monjalon <thomas@monjalon.net>]

28/10/2021 16:15, Maxime Coquelin:
> This patch marks the vDPA driver APIs as internal and
> rename the corresponding header file to vdpa_driver.h.
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> 
> Hi Techboard,
> 
> Please vote for an exception for this unannounced API
> breakage.
[...]
>  lib/vhost/{rte_vdpa_dev.h => vdpa_driver.h} | 12 +++++++++---

Hiding more internal structs is a good breakage.

[...]
> --- a/lib/vhost/rte_vdpa_dev.h
> +++ b/lib/vhost/vdpa_driver.h
> +__rte_internal
>  struct rte_vdpa_device *
>  rte_vdpa_register_device(struct rte_device *rte_dev,
>  		struct rte_vdpa_dev_ops *ops);
[...]
> +__rte_internal
>  int
>  rte_vdpa_unregister_device(struct rte_vdpa_device *dev);
[...]
> +__rte_internal
>  int
>  rte_vhost_host_notifier_ctrl(int vid, uint16_t qid, bool enable);
[...]
> +__rte_internal
>  int
>  rte_vdpa_relay_vring_used(int vid, uint16_t qid, void *vring_m);
[...]
> --- a/lib/vhost/version.map
> +++ b/lib/vhost/version.map
> -	rte_vdpa_register_device;
> -	rte_vdpa_relay_vring_used;
> -	rte_vdpa_unregister_device;
> -	rte_vhost_host_notifier_ctrl;

OK to remove these functions from the ABI
and mark them internal.

I suppose this breakage should not hurt too much,
as I don't see the need for out-of-tree vDPA drivers.
Of course it is always better to announce such change,
but it would be a pity to wait one more year for hiding this.

Acked-by: Thomas Monjalon <thomas@monjalon.net>