All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Dooley, Brian" <brian.dooley@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	stable@dpdk.org, "Nicolau, Radu" <radu.nicolau@intel.com>,
	Akhil Goyal <gakhil@marvell.com>,
	"Power, Ciara" <ciara.power@intel.com>
Subject: Re: [PATCH] examples/ipsec-secgw: fix partial overflow
Date: Wed, 22 Nov 2023 17:37:47 +0100	[thread overview]
Message-ID: <2090975.KlZ2vcFHjT@thomas> (raw)
In-Reply-To: <SN7PR11MB763993AF1D0FB06051186E48E6B1A@SN7PR11MB7639.namprd11.prod.outlook.com>

> > Case of partial overflow detected with ASan. Added extra padding to cdev_key
> > structure.
> > 
> > This structure is used for the key in hash table.
> > Padding is added to force the struct to use 8 bytes, to ensure memory is
> > notread past this structs boundary (the hash key calculation reads 8 bytes if
> > this struct is size 5 bytes).
> > The padding should be zeroed.
> > If fields are modified in this struct, the padding must be updated to ensure
> > multiple of 8 bytes size overall.
> > 
> > Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
> > Cc: sergio.gonzalez.monroy@intel.com
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Brian Dooley <brian.dooley@intel.com>
> 
> Acked-by: Ciara Power <ciara.power@intel.com>

Applied and made the comment simpler with this:

  uint8_t padding[3]; /* padding to 8-byte size should be zeroed */




  reply	other threads:[~2023-11-22 16:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-15 12:31 [PATCH] examples/ipsec-secgw: fix partial overflow Brian Dooley
2023-11-15 16:24 ` Power, Ciara
2023-11-22 16:37   ` Thomas Monjalon [this message]
2023-11-23 10:48     ` Dooley, Brian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2090975.KlZ2vcFHjT@thomas \
    --to=thomas@monjalon.net \
    --cc=brian.dooley@intel.com \
    --cc=ciara.power@intel.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=radu.nicolau@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.