From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Wed, 02 Aug 2017 17:11:41 +0300 Subject: [PATCH v2 1/4] drm/bridge: dw-hdmi: add cec notifier support In-Reply-To: References: <20170731142906.GX31807@n2100.armlinux.org.uk> Message-ID: <2091520.p8lH1xBY9c@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Russell, Thank you for the patch. On Monday 31 Jul 2017 15:29:41 Russell King wrote: > Add CEC notifier support to the HDMI bridge driver, so that the CEC > part of the IP can receive its physical address. > > Signed-off-by: Russell King > --- > drivers/gpu/drm/bridge/synopsys/Kconfig | 1 + > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 22 +++++++++++++++++++++- > 2 files changed, 22 insertions(+), 1 deletion(-) [snip] > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index > ead11242c4b9..82e55ee8e4fa 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c [snip] > @@ -2376,6 +2387,12 @@ __dw_hdmi_probe(struct platform_device *pdev, > if (ret) > goto err_iahb; > > + hdmi->cec_notifier = cec_notifier_get(dev); > + if (!hdmi->cec_notifier) { > + ret = -ENOMEM; > + goto err_iahb; > + } > + > /* > * To prevent overflows in HDMI_IH_FC_STAT2, set the clk regenerator > * N and cts values before enabling phy > @@ -2452,6 +2469,9 @@ __dw_hdmi_probe(struct platform_device *pdev, > hdmi->ddc = NULL; > } > > + if (hdmi->cec_notifier) > + cec_notifier_put(hdmi->cec_notifier); > + > clk_disable_unprepare(hdmi->iahb_clk); > err_isfr: > clk_disable_unprepare(hdmi->isfr_clk); I'm not very familiar yet with the CEC API so I made have missed something, but shouldn't you call cec_notifier_put() in the remove() handler ? -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 1/4] drm/bridge: dw-hdmi: add cec notifier support Date: Wed, 02 Aug 2017 17:11:41 +0300 Message-ID: <2091520.p8lH1xBY9c@avalon> References: <20170731142906.GX31807@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4496A88F61 for ; Wed, 2 Aug 2017 14:11:29 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: Hans Verkuil , Russell King , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org SGkgUnVzc2VsbCwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gTW9uZGF5IDMxIEp1bCAy MDE3IDE1OjI5OjQxIFJ1c3NlbGwgS2luZyB3cm90ZToKPiBBZGQgQ0VDIG5vdGlmaWVyIHN1cHBv cnQgdG8gdGhlIEhETUkgYnJpZGdlIGRyaXZlciwgc28gdGhhdCB0aGUgQ0VDCj4gcGFydCBvZiB0 aGUgSVAgY2FuIHJlY2VpdmUgaXRzIHBoeXNpY2FsIGFkZHJlc3MuCj4gCj4gU2lnbmVkLW9mZi1i eTogUnVzc2VsbCBLaW5nIDxybWsra2VybmVsQGFybWxpbnV4Lm9yZy51az4KPiAtLS0KPiAgZHJp dmVycy9ncHUvZHJtL2JyaWRnZS9zeW5vcHN5cy9LY29uZmlnICAgfCAgMSArCj4gIGRyaXZlcnMv Z3B1L2RybS9icmlkZ2Uvc3lub3BzeXMvZHctaGRtaS5jIHwgMjIgKysrKysrKysrKysrKysrKysr KysrLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkK CltzbmlwXQoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9zeW5vcHN5cy9k dy1oZG1pLmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc3lub3BzeXMvZHctaGRtaS5jIGlu ZGV4Cj4gZWFkMTEyNDJjNGI5Li44MmU1NWVlOGU0ZmEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2JyaWRnZS9zeW5vcHN5cy9kdy1oZG1pLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v YnJpZGdlL3N5bm9wc3lzL2R3LWhkbWkuYwoKW3NuaXBdCgo+IEBAIC0yMzc2LDYgKzIzODcsMTIg QEAgX19kd19oZG1pX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYsCj4gIAlpZiAo cmV0KQo+ICAJCWdvdG8gZXJyX2lhaGI7Cj4gCj4gKwloZG1pLT5jZWNfbm90aWZpZXIgPSBjZWNf bm90aWZpZXJfZ2V0KGRldik7Cj4gKwlpZiAoIWhkbWktPmNlY19ub3RpZmllcikgewo+ICsJCXJl dCA9IC1FTk9NRU07Cj4gKwkJZ290byBlcnJfaWFoYjsKPiArCX0KPiArCj4gIAkvKgo+ICAJICog VG8gcHJldmVudCBvdmVyZmxvd3MgaW4gSERNSV9JSF9GQ19TVEFUMiwgc2V0IHRoZSBjbGsgcmVn ZW5lcmF0b3IKPiAgCSAqIE4gYW5kIGN0cyB2YWx1ZXMgYmVmb3JlIGVuYWJsaW5nIHBoeQo+IEBA IC0yNDUyLDYgKzI0NjksOSBAQCBfX2R3X2hkbWlfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2Rldmlj ZSAqcGRldiwKPiAgCQloZG1pLT5kZGMgPSBOVUxMOwo+ICAJfQo+IAo+ICsJaWYgKGhkbWktPmNl Y19ub3RpZmllcikKPiArCQljZWNfbm90aWZpZXJfcHV0KGhkbWktPmNlY19ub3RpZmllcik7Cj4g Kwo+ICAJY2xrX2Rpc2FibGVfdW5wcmVwYXJlKGhkbWktPmlhaGJfY2xrKTsKPiAgZXJyX2lzZnI6 Cj4gIAljbGtfZGlzYWJsZV91bnByZXBhcmUoaGRtaS0+aXNmcl9jbGspOwoKSSdtIG5vdCB2ZXJ5 IGZhbWlsaWFyIHlldCB3aXRoIHRoZSBDRUMgQVBJIHNvIEkgbWFkZSBoYXZlIG1pc3NlZCBzb21l dGhpbmcsIApidXQgc2hvdWxkbid0IHlvdSBjYWxsIGNlY19ub3RpZmllcl9wdXQoKSBpbiB0aGUg cmVtb3ZlKCkgaGFuZGxlciA/CgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=