From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YFZaP-0005SU-R8 for mharc-qemu-trivial@gnu.org; Sun, 25 Jan 2015 21:39:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37554) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFZaM-0005NC-0N for qemu-trivial@nongnu.org; Sun, 25 Jan 2015 21:39:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFZaI-0006Gk-OI for qemu-trivial@nongnu.org; Sun, 25 Jan 2015 21:39:29 -0500 Received: from mx4-phx2.redhat.com ([209.132.183.25]:43198) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFZaI-0006Gg-9b; Sun, 25 Jan 2015 21:39:26 -0500 Received: from zmail14.collab.prod.int.phx2.redhat.com (zmail14.collab.prod.int.phx2.redhat.com [10.5.83.16]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id t0Q2dL5k016890; Sun, 25 Jan 2015 21:39:21 -0500 Date: Sun, 25 Jan 2015 21:39:20 -0500 (EST) From: Alex Williamson To: Chen Fan Message-ID: <2091737990.255560.1422239960803.JavaMail.zimbra@redhat.com> In-Reply-To: <54C5A408.5000001@cn.fujitsu.com> References: <1421898608-10313-1-git-send-email-chen.fan.fnst@cn.fujitsu.com> <54C0B156.3080608@linaro.org> <54C59333.8080005@cn.fujitsu.com> <1400861803.231065.1422237980435.JavaMail.zimbra@redhat.com> <54C5A408.5000001@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.6] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - GC39 (Linux)/8.0.6_GA_5922) Thread-Topic: vfio: fix wrong initialize vfio_group_list Thread-Index: 9hs57a7Bbdu6NxycDqhini9kMIba7Q== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 209.132.183.25 Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Eric Auger Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] vfio: fix wrong initialize vfio_group_list X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jan 2015 02:39:31 -0000 ----- Original Message ----- > > On 01/26/2015 10:06 AM, Alex Williamson wrote: > > > > ----- Original Message ----- > >> CC: qemu-trivial@nongnu.org > >> > >> On 01/22/2015 04:14 PM, Eric Auger wrote: > >>> Hi Chen, > >>> > >>> thanks for correcting this mistake I introduced when moving code from > >>> pci to common. > >> so, can you check in this patch? > > I've got it queued up and while it's clearly an error, I don't see that the > > fix actually changes the resulting code, the parameter is ignored in the > > macro. Am I missing something? If that's the case, I'll include it in my > > next pull request, but I don't see any pressing reason to rush that > > request. Thanks, > Yes, this patch can not affect the result of the code execution for > now, but I think it is also a typo mistake, if the macro > QLIST_HEAD_INITIALIZER > will be changed and using the parameter in the future, this error will > be difficultly found. I think the earlier found the earlier fixed. Yes, it's obviously an error and I'll get it in before QEMU 2.3, likely within the next week or so. Thanks, Alex > >>> On 01/22/2015 04:50 AM, Chen Fan wrote: > >>>> Signed-off-by: Chen Fan > >>>> --- > >>>> hw/vfio/common.c | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/hw/vfio/common.c b/hw/vfio/common.c > >>>> index cf483ff..e71385e 100644 > >>>> --- a/hw/vfio/common.c > >>>> +++ b/hw/vfio/common.c > >>>> @@ -32,7 +32,7 @@ > >>>> #include "trace.h" > >>>> > >>>> struct vfio_group_head vfio_group_list = > >>>> - QLIST_HEAD_INITIALIZER(vfio_address_spaces); > >>>> + QLIST_HEAD_INITIALIZER(vfio_group_list); > >>>> struct vfio_as_head vfio_address_spaces = > >>>> QLIST_HEAD_INITIALIZER(vfio_address_spaces); > >>>> > >>>> > >> > > . > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFZaO-0005Pw-GQ for qemu-devel@nongnu.org; Sun, 25 Jan 2015 21:39:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFZaN-0006I4-6S for qemu-devel@nongnu.org; Sun, 25 Jan 2015 21:39:32 -0500 Date: Sun, 25 Jan 2015 21:39:20 -0500 (EST) From: Alex Williamson Message-ID: <2091737990.255560.1422239960803.JavaMail.zimbra@redhat.com> In-Reply-To: <54C5A408.5000001@cn.fujitsu.com> References: <1421898608-10313-1-git-send-email-chen.fan.fnst@cn.fujitsu.com> <54C0B156.3080608@linaro.org> <54C59333.8080005@cn.fujitsu.com> <1400861803.231065.1422237980435.JavaMail.zimbra@redhat.com> <54C5A408.5000001@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vfio: fix wrong initialize vfio_group_list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Fan Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Eric Auger ----- Original Message ----- > > On 01/26/2015 10:06 AM, Alex Williamson wrote: > > > > ----- Original Message ----- > >> CC: qemu-trivial@nongnu.org > >> > >> On 01/22/2015 04:14 PM, Eric Auger wrote: > >>> Hi Chen, > >>> > >>> thanks for correcting this mistake I introduced when moving code from > >>> pci to common. > >> so, can you check in this patch? > > I've got it queued up and while it's clearly an error, I don't see that the > > fix actually changes the resulting code, the parameter is ignored in the > > macro. Am I missing something? If that's the case, I'll include it in my > > next pull request, but I don't see any pressing reason to rush that > > request. Thanks, > Yes, this patch can not affect the result of the code execution for > now, but I think it is also a typo mistake, if the macro > QLIST_HEAD_INITIALIZER > will be changed and using the parameter in the future, this error will > be difficultly found. I think the earlier found the earlier fixed. Yes, it's obviously an error and I'll get it in before QEMU 2.3, likely within the next week or so. Thanks, Alex > >>> On 01/22/2015 04:50 AM, Chen Fan wrote: > >>>> Signed-off-by: Chen Fan > >>>> --- > >>>> hw/vfio/common.c | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/hw/vfio/common.c b/hw/vfio/common.c > >>>> index cf483ff..e71385e 100644 > >>>> --- a/hw/vfio/common.c > >>>> +++ b/hw/vfio/common.c > >>>> @@ -32,7 +32,7 @@ > >>>> #include "trace.h" > >>>> > >>>> struct vfio_group_head vfio_group_list = > >>>> - QLIST_HEAD_INITIALIZER(vfio_address_spaces); > >>>> + QLIST_HEAD_INITIALIZER(vfio_group_list); > >>>> struct vfio_as_head vfio_address_spaces = > >>>> QLIST_HEAD_INITIALIZER(vfio_address_spaces); > >>>> > >>>> > >> > > . > > > >