From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] lib/librte_ether: bypass code cleanup
Date: Mon, 11 Jul 2016 09:11:15 +0200
Message-ID: <2092181.9Q4Kasxdod@xps13>
References: <1468218079-8064-1-git-send-email-wenzhuo.lu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Wenzhuo Lu <wenzhuo.lu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f54.google.com (mail-lf0-f54.google.com
 [209.85.215.54]) by dpdk.org (Postfix) with ESMTP id 0A1362B98
 for <dev@dpdk.org>; Mon, 11 Jul 2016 09:11:19 +0200 (CEST)
Received: by mail-lf0-f54.google.com with SMTP id f6so63387268lfg.0
 for <dev@dpdk.org>; Mon, 11 Jul 2016 00:11:19 -0700 (PDT)
In-Reply-To: <1468218079-8064-1-git-send-email-wenzhuo.lu@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-07-11 14:21, Wenzhuo Lu:
> In testpmd code, device id is used directly to check if bypass
> is supported. But APP should not know the details of HW, the NIC
> specific info should not be exposed here.

Right

> This patch adds a new rte API to check if bypass is supported.

Hmmm. It's true it is cleaner. But I am not sure having a generic API
for bypass is a good idea at all.
I was thinking to totally remove it.
Maybe we can try to have a specific API by including ixgbe_bypass.h in
the application.