All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jyri Sarha <jsarha@ti.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 06/16] drm/omap: remove dma & vrfb rotation
Date: Wed, 24 May 2017 13:53:50 +0300	[thread overview]
Message-ID: <2092434.mfb577c0us@avalon> (raw)
In-Reply-To: <6d4029b0-ed40-99a3-1e3e-ada2fd95cbf6@ti.com>

Hi Tomi,

On Wednesday 24 May 2017 13:13:08 Tomi Valkeinen wrote:
> On 24/05/17 12:31, Laurent Pinchart wrote:
> > On Thursday 04 May 2017 13:23:22 Tomi Valkeinen wrote:
> >> We have three rotation methods supported by the SoCs with DSS: DMA,
> >> VRFB and TILER.
> >> 
> >> DMA rotation works in theory on all DSS platforms, but in practice it's
> >> unusable due to the huge amount of memory bandwidth it uses, and has
> >> never really been used.
> >> 
> >> VRFB is available on OMAP3, but is not supported by omapdrm, even though
> >> we have some code for it in the dispc driver.
> >> 
> >> TILER is supported on OMAP4/OMAP5/DRA7/AM5 platforms, but has some
> >> driver bugs.
> >> 
> >> To clean up the driver to help fixing the TILER issues, this patch drops
> >> the DMA and VRFB rotation support, leaving only TILER rotation.
> > 
> > I'm fine dropping DMA rotation, but I have mixed feelings about VRFB. Yes,
> > it doesn't work at the moment, but I know users of VRFB with the
> > omap_vout driver who would really like to switch to omapdrm. Porting VRFB
> > from omap_vout to omapdrm has been on my to-do list for a long time (with
> > a low priority unfortunately). As an added bonus, it would allow dropping
> > the omap_vout driver at some point.
> > 
> > What would you think about dropping DMA but keeping VRFB for now ?
> 
> This patch doesn't remove that much about vrfb, just the row/pix inc
> calculations. The main vrfb file is still there, for omapfb. I'm happy
> to add it back when someone has a working prototype for omapdrm+vrfb,
> but to be honest, I won't hold my breath =).
> 
> I really want to clean up the dispc driver as much as possible, as it's
> such a messy piece of code, supporting so many DSS IP versions. I
> believe we'll get a cleaner version if we add the vrfb back from scratch.

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-05-24 10:53 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04 10:23 [PATCH 00/16] drm/omap: misc cleanups and pixel format change Tomi Valkeinen
2017-05-04 10:23 ` [PATCH 01/16] drm/omap: fix passing rotation parameter to dispc Tomi Valkeinen
2017-05-04 10:23 ` [PATCH 02/16] drm/omap: fix setting & clearing DOUBLESTRIDE Tomi Valkeinen
2017-05-24 12:36   ` Laurent Pinchart
2017-05-04 10:23 ` [PATCH 03/16] drm/omap: remove CLUT Tomi Valkeinen
2017-05-24 12:37   ` Laurent Pinchart
2017-05-04 10:23 ` [PATCH 04/16] drm/omap: ratelimit OCP error Tomi Valkeinen
2017-05-24 12:38   ` Laurent Pinchart
2017-05-04 10:23 ` [PATCH 05/16] drm/omap: remove rfbi Tomi Valkeinen
2017-05-04 10:23 ` [PATCH 06/16] drm/omap: remove dma & vrfb rotation Tomi Valkeinen
2017-05-24  9:31   ` Laurent Pinchart
2017-05-24 10:13     ` Tomi Valkeinen
2017-05-24 10:53       ` Laurent Pinchart [this message]
2017-05-04 10:23 ` [PATCH 07/16] drm/omap: cleanup offset calculation Tomi Valkeinen
2017-05-24  9:33   ` Laurent Pinchart
2017-05-04 10:23 ` [PATCH 08/16] drm/omap: add format_is_yuv() helper Tomi Valkeinen
2017-05-24  9:38   ` Laurent Pinchart
2017-05-04 10:23 ` [PATCH 09/16] drm/omap: remove unneeded prototypes Tomi Valkeinen
2017-05-24  9:43   ` Laurent Pinchart
2017-05-04 10:23 ` [PATCH 10/16] drm/omap: remove unused 'supported_modes' field Tomi Valkeinen
2017-05-24  9:46   ` Laurent Pinchart
2017-05-04 10:23 ` [PATCH 11/16] drm/omap: change supported_modes to an array Tomi Valkeinen
2017-05-24 10:44   ` Laurent Pinchart
2017-05-04 10:23 ` [PATCH 12/16] drm/omap: use DRM_FORMAT_* instead of OMAP_DSS_COLOR_* Tomi Valkeinen
2017-05-24 10:36   ` Laurent Pinchart
2017-05-04 10:23 ` [PATCH 13/16] drm/omap: use u32 instead of enum omap_color_mode Tomi Valkeinen
2017-05-24 10:28   ` Laurent Pinchart
2017-05-24 10:37     ` Tomi Valkeinen
2017-05-24 10:46       ` Laurent Pinchart
2017-05-24 11:01         ` Tomi Valkeinen
2017-05-04 10:23 ` [PATCH 14/16] drm/omap: remove omap_framebuffer_get_formats() Tomi Valkeinen
2017-05-24 10:33   ` Laurent Pinchart
2017-05-04 10:23 ` [PATCH 15/16] drm/omap: cleanup formats array Tomi Valkeinen
2017-05-24 10:48   ` Laurent Pinchart
2017-05-04 10:23 ` [PATCH 16/16] drm/omap: rename color_mode to fourcc Tomi Valkeinen
2017-05-24 10:49   ` Laurent Pinchart
2017-05-16  6:41 ` [PATCH 00/16] drm/omap: misc cleanups and pixel format change Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2092434.mfb577c0us@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.