All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH] fib: fix adding default route overwriting entire table
Date: Tue, 17 Oct 2023 15:26:09 +0200	[thread overview]
Message-ID: <20959154.0c2gjJ1VT2@thomas> (raw)
In-Reply-To: <20231002151148.675857-1-vladimir.medvedkin@intel.com>

02/10/2023 17:11, Vladimir Medvedkin:
> When FIB contains any route covering last ip address
> (255.255.255.255), upon adding a new default route
> the entire fib table will be overwritten with corresponding
> default route next hop.
> 
> Previous fix added check for ledge against 0 for case
> if default route is added as a first route, however
> this check was also erroneously triggered in case when
> ledge was wrapped around the address space
> (this would happen if FIB contains any route covering
> last possible address - 255.255.255.255).
> 
> This fix prevents wrap around from happening.
> 
> Fixes: 880bc2b5f3bd ("fib: fix adding default route")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>

Applied, thanks.



      reply	other threads:[~2023-10-17 13:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-02 15:11 [PATCH] fib: fix adding default route overwriting entire table Vladimir Medvedkin
2023-10-17 13:26 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20959154.0c2gjJ1VT2@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.