From: Murray Jensen <Murray.Jensen@cmst.csiro.au>
To: linuxppc-embedded@lists.linuxppc.org
Subject: bug in m8260_mask_and_ack() in Linux/PPC 2.4.x ??
Date: Wed, 25 Oct 2000 14:32:28 +1100 [thread overview]
Message-ID: <2098.972444748@msa.cmst.csiro.au> (raw)
Either I'm going crazy, or this code in m8260_mask_and_ack(), in
arch/ppc/kernel/ppc8260_pic.c from the 2.4.x Linux/PPC source, is wrong...
--- arch/ppc/kernel/ppc8260_pic.c-dist Wed Oct 25 12:30:37 2000
+++ arch/ppc/kernel/ppc8260_pic.c Wed Oct 25 13:36:29 2000
@@ -79,7 +79,7 @@
sipnr = &(immr->im_intctl.ic_sipnrh);
ppc_cached_irq_mask[word] &= ~(1 << (31 - bit));
simr[word] = ppc_cached_irq_mask[word];
- sipnr[word] = 1 << bit;
+ sipnr[word] = 1 << (31 - bit);
}
struct hw_interrupt_type ppc8260_pic = {
In my MPC8260 User Manual, the SIMR_[HL] and SIPNR_[HL] have the same
bits in the same positions. Unless this has been changed in errata or
something, the 1 << bit is wrong, it should be 1 << (31 - bit). It seems
like a big obvious bug - maybe m8260_mask_and_ack() is never used...
Could someone confirm this please? Cheers!
Murray...
--
Murray Jensen, CSIRO Manufacturing Sci & Tech, Phone: +61 3 9662 7763
Locked Bag No. 9, Preston, Vic, 3072, Australia. Fax: +61 3 9662 7853
Internet: Murray.Jensen@cmst.csiro.au (old address was mjj@mlb.dmt.csiro.au)
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next reply other threads:[~2000-10-25 3:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-10-25 3:32 Murray Jensen [this message]
2000-10-25 18:12 ` bug in m8260_mask_and_ack() in Linux/PPC 2.4.x ?? Dan Malek
2000-10-25 19:22 ` Scott Iveland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2098.972444748@msa.cmst.csiro.au \
--to=murray.jensen@cmst.csiro.au \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.