From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 3/3] app/crypto-perf: introduce new performance test application Date: Mon, 09 Jan 2017 16:24:51 +0100 Message-ID: <2098042.frnbFPgmZm@xps13> References: <1480691702-4600-1-git-send-email-michalx.k.jastrzebski@intel.com> <1483635001-15473-1-git-send-email-slawomirx.mrozowicz@intel.com> <1483635001-15473-4-git-send-email-slawomirx.mrozowicz@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Piotr Azarewicz , Marcin Kerlin , Michal Kobylinski To: Slawomir Mrozowicz , Declan Doherty Return-path: Received: from mail-wj0-f177.google.com (mail-wj0-f177.google.com [209.85.210.177]) by dpdk.org (Postfix) with ESMTP id 448EB326C for ; Mon, 9 Jan 2017 16:24:53 +0100 (CET) Received: by mail-wj0-f177.google.com with SMTP id kq3so21267783wjc.0 for ; Mon, 09 Jan 2017 07:24:53 -0800 (PST) In-Reply-To: <1483635001-15473-4-git-send-email-slawomirx.mrozowicz@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-01-05 17:50, Slawomir Mrozowicz: > --- a/app/Makefile > +++ b/app/Makefile > @@ -38,5 +38,6 @@ DIRS-$(CONFIG_RTE_TEST_PMD) += test-pmd > DIRS-$(CONFIG_RTE_LIBRTE_CMDLINE) += cmdline_test > DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += proc_info > DIRS-$(CONFIG_RTE_LIBRTE_PDUMP) += pdump > +DIRS-$(CONFIG_RTE_APP_CRYPTO_PERF) += crypto-perf Could we rename the directory to test-crypto or test-crypto-perf for consistency? > --- /dev/null > +++ b/app/crypto-perf/Makefile [...] > +APP = dpdk-crypto-perf I think we should have "test" in the name of the app. dpdk-test-crypto? dpdk-test-crypto-perf?