From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:42194 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750776AbeBVU00 (ORCPT ); Thu, 22 Feb 2018 15:26:26 -0500 From: Laurent Pinchart To: Frank Rowand Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org Subject: Re: [PATCH v6 0/4] R-Car DU: Convert LVDS code to bridge driver Date: Thu, 22 Feb 2018 22:27:10 +0200 Message-ID: <2099183.6c7g0IDd6G@avalon> In-Reply-To: <1ffb9d8c-fde3-af3b-c9a7-caac5ec253eb@gmail.com> References: <20180222131336.7712-1-laurent.pinchart+renesas@ideasonboard.com> <1ffb9d8c-fde3-af3b-c9a7-caac5ec253eb@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Frank, On Thursday, 22 February 2018 22:23:20 EET Frank Rowand wrote: > On 02/22/18 05:13, Laurent Pinchart wrote: > > Hello, > > > > This patch series addresses a design mistake that dates back from the > > initial DU support. Support for the LVDS encoders, which are IP cores > > separate from the DU, was bundled in the DU driver. Worse, both the DU > > and LVDS were described through a single DT node. > > > > To fix the, patches 1/4 and 2/4 define new DT bindings for the LVDS > > encoders, and deprecate their description inside the DU bindings. To > > retain backward compatibility with existing DT, patch 3/4 then patch the > > device tree at runtime to convert the legacy bindings to the new ones. > > > > With the DT side addressed, patch 4/4 converts the LVDS support code to a > > separate bridge driver. > > > > I decided to go for live DT patching in patch 3/4 because implementing > > support for both the legacy and new bindings in the driver would have been > > very intrusive, and prevented further cleanups. This version relies more > > heavily on overlays to avoid touching the internals of the OF core > > compared to v2, even if manual fixes to the device tree are still needed. > > > > As all the patches but the last one have been acked, I plan to send a pull > > request by the end of the week if no new issue is discovered. > > > > Compared to v5, I've dropped the OF changeset halpers series as Frank > > raised concerns about hidding it in the middle of a driver patch series. > > I've thus copied the implementation of of_changeset_add_property_copy() > > in the driver to avoid blocking this series. The function arguments are > > identical, so when the OF changeset helpers will land it will be very > > easy to drop the private copy and use the > > of_changeset_add_property_copy() helper. > > Thank you Laurent. > > My issues with that are procedural, and I'll reply later about this in the > v4 patch thread, where I raised the issue. (For the peanut gallery, I > replied in thread v4 _after_ Laurent sent v5, so Laurent did not ignore > me in v5.) I would have waited for your ack anyway :-) > My technical comments are more relevent than my process comments, in terms > of helping Laurent get his driver submitted, so I will delay the process > comments. Thank you. > My technical comments will be in reply to patch 3/4. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v6 0/4] R-Car DU: Convert LVDS code to bridge driver Date: Thu, 22 Feb 2018 22:27:10 +0200 Message-ID: <2099183.6c7g0IDd6G@avalon> References: <20180222131336.7712-1-laurent.pinchart+renesas@ideasonboard.com> <1ffb9d8c-fde3-af3b-c9a7-caac5ec253eb@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1ffb9d8c-fde3-af3b-c9a7-caac5ec253eb@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Frank Rowand Cc: linux-renesas-soc@vger.kernel.org, Laurent Pinchart , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org SGkgRnJhbmssCgpPbiBUaHVyc2RheSwgMjIgRmVicnVhcnkgMjAxOCAyMjoyMzoyMCBFRVQgRnJh bmsgUm93YW5kIHdyb3RlOgo+IE9uIDAyLzIyLzE4IDA1OjEzLCBMYXVyZW50IFBpbmNoYXJ0IHdy b3RlOgo+ID4gSGVsbG8sCj4gPiAKPiA+IFRoaXMgcGF0Y2ggc2VyaWVzIGFkZHJlc3NlcyBhIGRl c2lnbiBtaXN0YWtlIHRoYXQgZGF0ZXMgYmFjayBmcm9tIHRoZQo+ID4gaW5pdGlhbCBEVSBzdXBw b3J0LiBTdXBwb3J0IGZvciB0aGUgTFZEUyBlbmNvZGVycywgd2hpY2ggYXJlIElQIGNvcmVzCj4g PiBzZXBhcmF0ZSBmcm9tIHRoZSBEVSwgd2FzIGJ1bmRsZWQgaW4gdGhlIERVIGRyaXZlci4gV29y c2UsIGJvdGggdGhlIERVCj4gPiBhbmQgTFZEUyB3ZXJlIGRlc2NyaWJlZCB0aHJvdWdoIGEgc2lu Z2xlIERUIG5vZGUuCj4gPiAKPiA+IFRvIGZpeCB0aGUsIHBhdGNoZXMgMS80IGFuZCAyLzQgZGVm aW5lIG5ldyBEVCBiaW5kaW5ncyBmb3IgdGhlIExWRFMKPiA+IGVuY29kZXJzLCBhbmQgZGVwcmVj YXRlIHRoZWlyIGRlc2NyaXB0aW9uIGluc2lkZSB0aGUgRFUgYmluZGluZ3MuIFRvCj4gPiByZXRh aW4gYmFja3dhcmQgY29tcGF0aWJpbGl0eSB3aXRoIGV4aXN0aW5nIERULCBwYXRjaCAzLzQgdGhl biBwYXRjaCB0aGUKPiA+IGRldmljZSB0cmVlIGF0IHJ1bnRpbWUgdG8gY29udmVydCB0aGUgbGVn YWN5IGJpbmRpbmdzIHRvIHRoZSBuZXcgb25lcy4KPiA+IAo+ID4gV2l0aCB0aGUgRFQgc2lkZSBh ZGRyZXNzZWQsIHBhdGNoIDQvNCBjb252ZXJ0cyB0aGUgTFZEUyBzdXBwb3J0IGNvZGUgdG8gYQo+ ID4gc2VwYXJhdGUgYnJpZGdlIGRyaXZlci4KPiA+IAo+ID4gSSBkZWNpZGVkIHRvIGdvIGZvciBs aXZlIERUIHBhdGNoaW5nIGluIHBhdGNoIDMvNCBiZWNhdXNlIGltcGxlbWVudGluZwo+ID4gc3Vw cG9ydCBmb3IgYm90aCB0aGUgbGVnYWN5IGFuZCBuZXcgYmluZGluZ3MgaW4gdGhlIGRyaXZlciB3 b3VsZCBoYXZlIGJlZW4KPiA+IHZlcnkgaW50cnVzaXZlLCBhbmQgcHJldmVudGVkIGZ1cnRoZXIg Y2xlYW51cHMuIFRoaXMgdmVyc2lvbiByZWxpZXMgbW9yZQo+ID4gaGVhdmlseSBvbiBvdmVybGF5 cyB0byBhdm9pZCB0b3VjaGluZyB0aGUgaW50ZXJuYWxzIG9mIHRoZSBPRiBjb3JlCj4gPiBjb21w YXJlZCB0byB2MiwgZXZlbiBpZiBtYW51YWwgZml4ZXMgdG8gdGhlIGRldmljZSB0cmVlIGFyZSBz dGlsbCBuZWVkZWQuCj4gPiAKPiA+IEFzIGFsbCB0aGUgcGF0Y2hlcyBidXQgdGhlIGxhc3Qgb25l IGhhdmUgYmVlbiBhY2tlZCwgSSBwbGFuIHRvIHNlbmQgYSBwdWxsCj4gPiByZXF1ZXN0IGJ5IHRo ZSBlbmQgb2YgdGhlIHdlZWsgaWYgbm8gbmV3IGlzc3VlIGlzIGRpc2NvdmVyZWQuCj4gPiAKPiA+ IENvbXBhcmVkIHRvIHY1LCBJJ3ZlIGRyb3BwZWQgdGhlIE9GIGNoYW5nZXNldCBoYWxwZXJzIHNl cmllcyBhcyBGcmFuawo+ID4gcmFpc2VkIGNvbmNlcm5zIGFib3V0IGhpZGRpbmcgaXQgaW4gdGhl IG1pZGRsZSBvZiBhIGRyaXZlciBwYXRjaCBzZXJpZXMuCj4gPiBJJ3ZlIHRodXMgY29waWVkIHRo ZSBpbXBsZW1lbnRhdGlvbiBvZiBvZl9jaGFuZ2VzZXRfYWRkX3Byb3BlcnR5X2NvcHkoKQo+ID4g aW4gdGhlIGRyaXZlciB0byBhdm9pZCBibG9ja2luZyB0aGlzIHNlcmllcy4gVGhlIGZ1bmN0aW9u IGFyZ3VtZW50cyBhcmUKPiA+IGlkZW50aWNhbCwgc28gd2hlbiB0aGUgT0YgY2hhbmdlc2V0IGhl bHBlcnMgd2lsbCBsYW5kIGl0IHdpbGwgYmUgdmVyeQo+ID4gZWFzeSB0byBkcm9wIHRoZSBwcml2 YXRlIGNvcHkgYW5kIHVzZSB0aGUKPiA+IG9mX2NoYW5nZXNldF9hZGRfcHJvcGVydHlfY29weSgp IGhlbHBlci4KPiAKPiBUaGFuayB5b3UgTGF1cmVudC4KPiAKPiBNeSBpc3N1ZXMgd2l0aCB0aGF0 IGFyZSBwcm9jZWR1cmFsLCBhbmQgSSdsbCByZXBseSBsYXRlciBhYm91dCB0aGlzIGluIHRoZQo+ IHY0IHBhdGNoIHRocmVhZCwgd2hlcmUgSSByYWlzZWQgdGhlIGlzc3VlLiAgKEZvciB0aGUgcGVh bnV0IGdhbGxlcnksIEkKPiByZXBsaWVkIGluIHRocmVhZCB2NCBfYWZ0ZXJfIExhdXJlbnQgc2Vu dCB2NSwgc28gTGF1cmVudCBkaWQgbm90IGlnbm9yZQo+IG1lIGluIHY1LikKCkkgd291bGQgaGF2 ZSB3YWl0ZWQgZm9yIHlvdXIgYWNrIGFueXdheSA6LSkKCj4gTXkgdGVjaG5pY2FsIGNvbW1lbnRz IGFyZSBtb3JlIHJlbGV2ZW50IHRoYW4gbXkgcHJvY2VzcyBjb21tZW50cywgaW4gdGVybXMKPiBv ZiBoZWxwaW5nIExhdXJlbnQgZ2V0IGhpcyBkcml2ZXIgc3VibWl0dGVkLCBzbyBJIHdpbGwgZGVs YXkgdGhlIHByb2Nlc3MKPiBjb21tZW50cy4KClRoYW5rIHlvdS4gCgo+IE15IHRlY2huaWNhbCBj b21tZW50cyB3aWxsIGJlIGluIHJlcGx5IHRvIHBhdGNoIDMvNC4KCi0tIApSZWdhcmRzLAoKTGF1 cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg==