From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iBMZ5-0002lC-Tj for ath10k@lists.infradead.org; Fri, 20 Sep 2019 17:19:29 +0000 Received: by mail-wr1-x441.google.com with SMTP id h7so7513673wrw.8 for ; Fri, 20 Sep 2019 10:19:26 -0700 (PDT) From: Christian Lamparter Subject: Re: [PATCH] ath10k: restore QCA9880-AR1A (v1) detection Date: Fri, 20 Sep 2019 19:19:06 +0200 Message-ID: <2099574.gZacamft7q@debian64> In-Reply-To: <20190917064412.C2E0D61572@smtp.codeaurora.org> References: <20190906215423.23589-1-chunkeey@gmail.com> <20190917064412.C2E0D61572@smtp.codeaurora.org> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: =?utf-8?B?TWljaGHFgg==?= Kazior , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org T24gVHVlc2RheSwgU2VwdGVtYmVyIDE3LCAyMDE5IDg6NDQ6MTIgQU0gQ0VTVCBLYWxsZSBWYWxv IHdyb3RlOgo+IENocmlzdGlhbiBMYW1wYXJ0ZXIgPGNodW5rZWV5QGdtYWlsLmNvbT4gd3JvdGU6 Cj4gCj4gPiBUaGlzIHBhdGNoIHJlc3RvcmVzIHRoZSBvbGQgYmVoYXZpb3IgdGhhdCByZWFkCj4g PiB0aGUgY2hpcF9pZCBvbiB0aGUgUUNBOTg4eCBiZWZvcmUgcmVzZXR0aW5nIHRoZQo+ID4gY2hp cC4gVGhpcyBuZWVkcyB0byBiZSBkb25lIGluIHRoaXMgb3JkZXIgc2luY2UKPiA+IHRoZSB1bnN1 cHBvcnRlZCBRQ0E5ODh4IEFSMUEgY2hpcHMgZmFsbCBvZmYgdGhlCj4gPiBidXMgd2hlbiByZXNl dHRlZC4gT3RoZXJ3aXNlIHRoZSBuZXh0IE1NSU8gT3AKPiA+IGFmdGVyIHRoZSByZXNldCBjYXVz ZXMgYSBCVVMgRVJST1IgYW5kIHBhbmljLgo+ID4gCj4gPiBDYzogc3RhYmxlQHZnZXIua2VybmVs Lm9yZwo+ID4gRml4ZXM6IDFhN2ZlY2I3NjZjOCAoImF0aDEwazogcmVzZXQgY2hpcCBiZWZvcmUg cmVhZGluZyBjaGlwX2lkIGluIHByb2JlIikKPiA+IFNpZ25lZC1vZmYtYnk6IENocmlzdGlhbiBM YW1wYXJ0ZXIgPGNodW5rZWV5QGdtYWlsLmNvbT4KPiAKPiBJJ2xsIGRyb3AgdGhpcyBhcyB0aGVy ZSdzIG5vIHBsYW4gdG8gc3VwcG9ydCBRQ0E5ODhYIGh3MS4wLgoKS2FsbGUsCgpJJ20gc3VycHJp c2VkIGFib3V0IHRoaXMuIEFuZCB5b3VyIGp1c3RpZmljYXRpb24KIm5vIHBsYW4gdG8gc3VwcG9y dCBRQ0E5ODhYIGh3MS4wIiBzZWVtcyB2ZXJ5IG9kZCBpbiB0aGlzIGNvbnRleHQsCmJlY2F1c2Ug dGhpcyBwYXRjaCBkb2VzIG5vdCBhZGQgYW55IHN1cHBvcnQgZm9yIHRoZSBRQ0E5ODhYIGh3MS4w LgoKQnV0LCBJIGNvdWxkIHNlZSBob3cgdGhlIG1haWxzL3JlcGxpZXMgZnJvbSBUb20gUHN5Ym9y ZyBkZXJhaWxlZCB0aGUKdG9waWMgaGVyZS4gVGhvdWdoLCBJJ20gbm90IHN1cmUgaWYgdGhpcyBp cyB0aGUgY2FzZSBvciBub3QuCgpTbyBsZXQgc2V0IHRoZSByZWNvcmQgc3RyYWlnaHQgYW5kIHNo b3cgeW91IHRoZSByZXN1bHQgb2YgaGF2aW5nIHRoYXQKcGF0Y2ggYXBwbGllZCBhbmQgbG9hZCBh dGgxMGtfcGNpIHdpdGggYSBRQ0E5ODgwIHYxIEFSMUE6CgpbIDE0OTEuNjIyMjgyXSBhdGgxMGtf cGNpIDAwMDA6MDA6MDAuMDogZGV2aWNlIDAwM2Mgd2l0aCBjaGlwX2lkIDA0MzIwMGZmIGlzbid0 IHN1cHBvcnRlZAoKKFN5c3RlbSBpcyBhbGwgZ29vZCEpCgpBbmQgd2l0aG91dCB0aGUgcGF0Y2g6 CgpbICA5MDAuMzIwMDAwXSBEYXRhIGJ1cyBlcnJvciwgZXBjID09IDg2YTlhMWIwLCByYSA9PSA4 NmE5YTRiMApbICA5MDAuMzIwMDAwXSBPb3BzWyMxXToKWyAgOTAwLjMyMDAwMF0gQ1BVOiAwIFBJ RDogODEyNyBDb21tOiBpbnNtb2QgTm90IHRhaW50ZWQgNS4yLjE2ICMxClsgIDkwMC4zMjAwMDBd IHRhc2s6IDg3OTBkZDUwIHRpOiA4NmEyYzAwMCB0YXNrLnRpOiA4NmEyYzAwMApbICA5MDAuMzIw MDAwXSAkIDAgICA6IDAwMDAwMDAwIDgwMzUwMDAwIGRlYWRjMGRlIDEwMDBmYzAzClsgIDkwMC4z MjAwMDBdICQgNCAgIDogYjIwODAwMDAgODc5MGRkNTAgMTAwMGZjMDAgZmZmZjAwZmUKWyAgOTAw LjMyMDAwMF0gJCA4ICAgOiA4NmEyZGZlMCAwMDAwZmMwMCAwMDAwMDAwMCAwMDAwMDAwMApbICA5 MDAuMzIwMDAwXSAkMTIgICA6IDAwMDAwMDA1IDAwMDAwMDAwIDAwMDAwMDAwIDAwNDIwMDAwClsg IDkwMC4zMjAwMDBdICQxNiAgIDogMDAwMDAwMDkgODc4OGQ0MDAgODY5ZjkwMDAgODc4MjE4MDAK WyAgOTAwLjMyMDAwMF0gJDIwICAgOiAwMDAwMDAwOSBiMjA4MDAwOCBiMjA4MDAwMCAwMDAwMDAw MQpbICA5MDAuMzIwMDAwXSAkMjQgICA6IDAwMDAwMDAwIDgwMDZiNzg0ICAgICAgICAgICAgICAg ICAgClsgIDkwMC4zMjAwMDBdICQyOCAgIDogODZhMmMwMDAgODZhMmRiYTggYjIwODAwMDQgODZh N2E1YjAKWyAgOTAwLjMyMDAwMF0gSGkgICAgOiAwMDAwMDBkMQpbICA5MDAuMzIwMDAwXSBMbyAg ICA6IDllYTg2MTgwClsgIDkwMC4zMjAwMDBdIGVwYyAgIDogODZhN2E1YjAgYXRoMTBrX3BjaV9j b2xkX3Jlc2V0KzB4Zjg4LzB4MWJiMCBbYXRoMTBrX3BjaV0KWyAgOTAwLjMyMDAwMF0gICAgIE5v dCB0YWludGVkClsgIDkwMC4zMjAwMDBdIHJhICAgIDogODZhN2E1YjAgYXRoMTBrX3BjaV9jb2xk X3Jlc2V0KzB4Zjg4LzB4MWJiMCBbYXRoMTBrX3BjaV0KWyAgOTAwLjMyMDAwMF0gU3RhdHVzOiAx MDAwZmMwMyBLRVJORUwgRVhMIElFIApbICA5MDAuMzIwMDAwXSBDYXVzZSA6IDQwODA4MDFjClsg IDkwMC4zMjAwMDBdIFBySWQgIDogMDAwMTk3NTAgKE1JUFMgNzRLYykKWyAgOTAwLjMyMDAwMF0g TW9kdWxlcyBsaW5rZWQgaW46IGF0aDEwa19wY2koKykgYXRoMTBrX2NvcmUgWy4uLl0KWyAgOTAw LjMyMDAwMF0gUHJvY2VzcyBpbnNtb2QgKHBpZDogMTEyNywgdGhyZWFkaW5mbz04NmEyYzAwMCwg dGFzaz04NzkwZGQ1MCwgdGxzPTc3NWIxNDQwKQpbICA5MDAuMzIwMDAwXSBTdGFjayA6IDgwMzAx ZDkwIDg3OTBkZDUwIDg3OTBkZDUwIDgwMzAxZDkwIDg3OTBjNDMwIDgwMDY3ZTc4IDAwMDAwMDAw IDg3ODIxODAwCiAgICAgICAgICAwMDA4MDAwMCAwMDAwMDAwMCA4MDM3MzkwMCA4NmEyZGMwYyA4 MDM3MzkwMCAwMDAwZWE4MCAwMDAwMDAwOSBiMjA4MDAwOAogICAgICAgICAgYjIwODAwMDAgMDAw MDAwMDEgODAzNzM5MDAgODAwNjY5NjQgODZhMmRjMGMgODAwODFlODAgODc5MGRkNTAgODZhNjM5 MjQKICAgICAgICAgIDAwMDAwMDAxIDAwMDAwMDAwIDAwMjAwMjAwIDAwMDBlYTgwIDgwMzczOTAw IDgwMDgxZTgwIDg3OTBkZDUwIGZmZmZmZmZmCiAgICAgICAgICA4Nzg4ZDQwMCAwMDAwMDAwOSA4 Nzg4ZDQwMCA4NmEyZGM1OCA4NzgyMTgwMCA4MDA4MjM5OCA4NmEyZGM1YyA4NmE3ZDE0MAogICAg ICAgICAgLi4uClsgIDkwMC4zMjAwMDBdIENhbGwgVHJhY2U6ClsgIDkwMC4zMjAwMDBdIFs8ODZh N2E1YjA+XSBhdGgxMGtfcGNpX2NvbGRfcmVzZXQrMHhmODgvMHgxYmIwIFthdGgxMGtfcGNpXQpb ICA5MDAuMzIwMDAwXSAKWyAgOTAwLjMyMDAwMF0gCkNvZGU6IDI0MTAwMDBhICAwYzA2MjFkMyAg MDJjMDIwMjEgPDMwNDIwNDAwPiAxMDQwMDAwNiAgMDAwMDIwMjEgIDI0MDQwMDAxICAwYzAyMDhk ZSAgMjYxMGZmZmYgClsgIDkwMC41NzAwMDBdIC0tLVsgZW5kIHRyYWNlIDFlNGUyYjdmZDRhYzll YjggXS0tLQpTZWdtZW50YXRpb24gZmF1bHQKCk5vdGljZSB0aGUgREFUQSBCVVMgRXJyb3IhIFRo ZSByb3V0ZXIgaXMgdW51c2FibGUgYXQgdGhhdCBwb2ludCBhbmQgbm8gbG9uZ2VyICJ3b3JraW5n Ii4KCgpBcyBmb3Igd2h5IHRoaXMgcGF0Y2ggd2FzIGNvZGVkIHRoaXMgd2F5LiBJdCdzIGJlY2F1 c2UgdGhpcyBwYXRjaCBmb2xsb3dzIE1pY2hhxYIgS2F6aW9yCnJlY29tbWVuZGF0aW9uIG9mIGhv dyB0byBoYW5kbGUgdGhpcyBjYXJkIGluIGhpcyByZXBseSB0byBhIHByZXZpb3VzIHRocmVhZCAK ImF0aDEwazogcmVzZXQgY2hpcCBhZnRlciBzdXBwb3J0ZWQgY2hlY2siIHJlZ2FyZGluZyB0aGUg c2FtZSBpc3N1ZS4gSGUgZGlkIGNoZWNrIGZvciBhClFDQTk4OFggSGFyZHdhcmUgYW5kIG9ubHkg dGhlbiBwZXJmb3JtIHRoZSBTT0NfQ0hJUF9JRF9BRERSRVNTIHJlYWQuCgo8aHR0cHM6Ly9wYXRj aHdvcmsua2VybmVsLm9yZy9wYXRjaC8xMDg2NjQxNy8jMjI1NDkwMTE+CnxUaGF0IG1ha2VzIHNl bnNlLCBidXQgSSBkb24ndCBzZWUgaG93IGJsYWNrbGlzdGluZyBwY2kgc2xvdHMgd291bGQKfGhl bHAgc29tZW9uZSBwdXR0aW5nIHYyIG5pYyBpbnRvIEM3djEgbW9ibz8gV29uJ3QgdGhlIHNsb3Qg YmUgdGhlIHNhbWUKfHJlZ2FyZGxlc3Mgd2hhdCBuaWMgaXMgcHV0Pwp8CnxUaGUgYmVzdCB0aGlu ZyBJIGNhbiBjb21lIHVwIHdpdGggaXMgc29tZXRoaW5nIGxpa2UgdGhpczoKfAp8LS0tIGEvZHJp dmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDEway9wY2kuYwp8KysrIGIvZHJpdmVycy9uZXQvd2ly ZWxlc3MvYXRoL2F0aDEway9wY2kuYwp8QEAgLTM2MjksNiArMzYyOSwxOSBAQCBzdGF0aWMgaW50 IGF0aDEwa19wY2lfcHJvYmUoc3RydWN0IHBjaV9kZXYgKnBkZXYsCnwgICAgICAgICAgICAgICAg Z290byBlcnJfZGVpbml0X2lycTsKfCAgICAgICAgfQp8CnwrICAgICAgIGlmIChod19yZXYgPT0g QVRIMTBLX0hXX1FDQTk4OFgpIHsKfCsgICAgICAgICAgICAgICAvKiB2MSBjYW4gY3Jhc2ggdGhl IHN5c3RlbSBvbiBjaGlwX3Jlc2V0KCkKfCsgICAgICAgICAgICAgICAgKiBzbyBhbGwgd2UgY2Fu IGRvIGlzIGtlZXAgb3VyIGZpbmdlcnMKfCsgICAgICAgICAgICAgICAgKiBjcm9zc2VkIHYyIG5l dmVyIHJlcG9ydHMgMCB3aXRob3V0IGEKfCsgICAgICAgICAgICAgICAgKiBjaGlwX3Jlc2V0KCkK fCsgICAgICAgICAgICAgICAgKi8KfCsgICAgICAgICAgICAgICBpZiAoYXRoMTBrX3BjaV9zb2Nf cmVhZDMyKGFyLCBTT0NfQ0hJUF9JRF9BRERSRVNTKSA9PSAwKSB7CnwrICAgICAgICAgICAgICAg ICAgICAgICBhdGgxMGtfZXJyKGFyLCAicWNhOTg4MCB2MSBpcyBjaGlwIG5vdCBzdXBwb3J0ZWQi KTsKfCsgICAgICAgICAgICAgICAgICAgICAgIHJldCA9IC1FTk9UU1VQOwp8KyAgICAgICAgICAg ICAgICAgICAgICAgZ290byBlcnJfZnJlZV9pcnE7CnwrICAgICAgICAgICAgICAgfQp8KyAgICAg ICB9CnwrCnwgICAgICAgIHJldCA9IGF0aDEwa19wY2lfY2hpcF9yZXNldChhcik7CnwgICAgICAg IGlmIChyZXQpIHsKfCAgICAgICAgICAgICAgICBhdGgxMGtfZXJyKGFyLCAiZmFpbGVkIHRvIHJl c2V0IGNoaXA6ICVkXG4iLCByZXQpOwp8CnxJIGRpZG4ndCB0ZXN0IGl0LiBTb21lb25lIG5lZWRz IHRvIGNvbXBpbGUgYW5kIHRlc3QgYW5kIG1ha2Ugc3VyZSB2Mgp8ZG9lc24ndCByZWdyZXNzIHdo ZW4gZncgaGFuZ3MgYW5kIGNvbGQgJiB3YXJtIGhvc3QgY3B1IHJlc2V0cyBhcmUKfG1peGVkIGlu LgoKSSBkbyBob3BlIHRoaXMgaGVscGVkICJ0byBjbGVhciB0aGluZ3MgdXAiIHNpbmNlIEkgZGlk IG5vdCBhZGQgc3VwcG9ydApmb3IgdGhlIFFDQTk4ODAgdjEgQVIxQSBoZXJlIGFuZCBkb24ndCBw bGFuIHRvIGRvIHNvLgoKUmVnYXJkcywKQ2hyaXN0aWFuCgoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBrQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,LOTS_OF_MONEY,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FD99C3A5A2 for ; Fri, 20 Sep 2019 17:19:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BE13208C0 for ; Fri, 20 Sep 2019 17:19:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s1Ic7nUw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729484AbfITRT2 (ORCPT ); Fri, 20 Sep 2019 13:19:28 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:43440 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729416AbfITRT2 (ORCPT ); Fri, 20 Sep 2019 13:19:28 -0400 Received: by mail-wr1-f65.google.com with SMTP id q17so7521141wrx.10 for ; Fri, 20 Sep 2019 10:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/lqDng+a1V5wthmlIGyTOvwnRwIUwaocc0044UXAv6k=; b=s1Ic7nUwmQyDdLG2cUmKuRHpjy2WyahzIJvuOlfDErVaXGlNnMZ9+mlxDAqttCSFkf PvMsjOZjM+ca+fUSB0Ad8GyCq/7mStyQgQJOD323/Hh9ZK9eZuqrBCPvTYWkOIv9Ff9Q YZUGDDSkiTixskLHbVAbK0MKz0nykVxIsILWlxzRLX+H6LPRt3SqMrtj9cW/8jQkXnQq fKiykPAXeljmC+w+97+vEs6AgTBVEz6y81lIqRX16wsmjEX/oqUAFUqhaqpHcgFaiKyc vb5is3n/BZPxWrbIvZvPYudWAcqlln+17U1F6ftTMXx3aY7CzHuuqKIIKEg8f3npM79M U9Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/lqDng+a1V5wthmlIGyTOvwnRwIUwaocc0044UXAv6k=; b=Hcddc2j2108x+3U7WS5cbXgr5NKivn44Mpq8uH1nOgFxHa0FliGz1hStxl9cochpYa KJzLXzgpU4wEuC9rz03TCK+2iXRnpvJ71ssfI5wcvkIeEGJCrJ//60+wVrhKE2Tr/Tia RbelLtQtRhsY7ZsiCuzKNXdSvLS2hxSVxMw9+lyoQtGTWNsuarX4mnjTEtnI0lEz67u9 pRvHH2m/T7M/uYpP3Lp34DRIeWZaLIKOA7prnPAr9xXnbjMoOwoClS1XsgV4FQQ1ppYM o9Rs4qomBahFpg9yrX+z0/sv1rk3geAia0W3NluDavdDfv2ex5afwafmgew/1S6N8N73 sgrQ== X-Gm-Message-State: APjAAAXaq2ZR7zR2NXM0WW6jo2EUgAhHuQWwscY78qbp2WyvLugRZW+9 v8/B51rkan1YXWUbyrpv8cQ= X-Google-Smtp-Source: APXvYqznlml5TsM2oJaPQk+gtt4tIbpBWdLUUfIKh6aUhUKRU7Ws0Sde/3wWVTbyCYPxaPqr/fGQaA== X-Received: by 2002:adf:f5cc:: with SMTP id k12mr11839628wrp.278.1568999964672; Fri, 20 Sep 2019 10:19:24 -0700 (PDT) Received: from debian64.daheim (p4FD09E69.dip0.t-ipconnect.de. [79.208.158.105]) by smtp.gmail.com with ESMTPSA id g185sm4932711wme.10.2019.09.20.10.19.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2019 10:19:23 -0700 (PDT) Received: from localhost.daheim ([127.0.0.1] helo=debian64.localnet) by debian64.daheim with esmtp (Exim 4.92.2) (envelope-from ) id 1iBMYl-00008S-Ph; Fri, 20 Sep 2019 19:19:10 +0200 From: Christian Lamparter To: Kalle Valo Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, =?utf-8?B?TWljaGHFgg==?= Kazior Subject: Re: [PATCH] ath10k: restore QCA9880-AR1A (v1) detection Date: Fri, 20 Sep 2019 19:19:06 +0200 Message-ID: <2099574.gZacamft7q@debian64> In-Reply-To: <20190917064412.C2E0D61572@smtp.codeaurora.org> References: <20190906215423.23589-1-chunkeey@gmail.com> <20190917064412.C2E0D61572@smtp.codeaurora.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tuesday, September 17, 2019 8:44:12 AM CEST Kalle Valo wrote: > Christian Lamparter wrote: >=20 > > This patch restores the old behavior that read > > the chip_id on the QCA988x before resetting the > > chip. This needs to be done in this order since > > the unsupported QCA988x AR1A chips fall off the > > bus when resetted. Otherwise the next MMIO Op > > after the reset causes a BUS ERROR and panic. > >=20 > > Cc: stable@vger.kernel.org > > Fixes: 1a7fecb766c8 ("ath10k: reset chip before reading chip_id in prob= e") > > Signed-off-by: Christian Lamparter >=20 > I'll drop this as there's no plan to support QCA988X hw1.0. Kalle, I'm surprised about this. And your justification "no plan to support QCA988X hw1.0" seems very odd in this context, because this patch does not add any support for the QCA988X hw1.0. But, I could see how the mails/replies from Tom Psyborg derailed the topic here. Though, I'm not sure if this is the case or not. So let set the record straight and show you the result of having that patch applied and load ath10k_pci with a QCA9880 v1 AR1A: [ 1491.622282] ath10k_pci 0000:00:00.0: device 003c with chip_id 043200ff i= sn't supported (System is all good!) And without the patch: [ 900.320000] Data bus error, epc =3D=3D 86a9a1b0, ra =3D=3D 86a9a4b0 [ 900.320000] Oops[#1]: [ 900.320000] CPU: 0 PID: 8127 Comm: insmod Not tainted 5.2.16 #1 [ 900.320000] task: 8790dd50 ti: 86a2c000 task.ti: 86a2c000 [ 900.320000] $ 0 : 00000000 80350000 deadc0de 1000fc03 [ 900.320000] $ 4 : b2080000 8790dd50 1000fc00 ffff00fe [ 900.320000] $ 8 : 86a2dfe0 0000fc00 00000000 00000000 [ 900.320000] $12 : 00000005 00000000 00000000 00420000 [ 900.320000] $16 : 00000009 8788d400 869f9000 87821800 [ 900.320000] $20 : 00000009 b2080008 b2080000 00000001 [ 900.320000] $24 : 00000000 8006b784 =20 [ 900.320000] $28 : 86a2c000 86a2dba8 b2080004 86a7a5b0 [ 900.320000] Hi : 000000d1 [ 900.320000] Lo : 9ea86180 [ 900.320000] epc : 86a7a5b0 ath10k_pci_cold_reset+0xf88/0x1bb0 [ath10k_= pci] [ 900.320000] Not tainted [ 900.320000] ra : 86a7a5b0 ath10k_pci_cold_reset+0xf88/0x1bb0 [ath10k_= pci] [ 900.320000] Status: 1000fc03 KERNEL EXL IE=20 [ 900.320000] Cause : 4080801c [ 900.320000] PrId : 00019750 (MIPS 74Kc) [ 900.320000] Modules linked in: ath10k_pci(+) ath10k_core [...] [ 900.320000] Process insmod (pid: 1127, threadinfo=3D86a2c000, task=3D879= 0dd50, tls=3D775b1440) [ 900.320000] Stack : 80301d90 8790dd50 8790dd50 80301d90 8790c430 80067e7= 8 00000000 87821800 00080000 00000000 80373900 86a2dc0c 80373900 0000ea80 00000009 b2= 080008 b2080000 00000001 80373900 80066964 86a2dc0c 80081e80 8790dd50 86= a63924 00000001 00000000 00200200 0000ea80 80373900 80081e80 8790dd50 ff= ffffff 8788d400 00000009 8788d400 86a2dc58 87821800 80082398 86a2dc5c 86= a7d140 ... [ 900.320000] Call Trace: [ 900.320000] [<86a7a5b0>] ath10k_pci_cold_reset+0xf88/0x1bb0 [ath10k_pci] [ 900.320000]=20 [ 900.320000]=20 Code: 2410000a 0c0621d3 02c02021 <30420400> 10400006 00002021 24040001 = 0c0208de 2610ffff=20 [ 900.570000] ---[ end trace 1e4e2b7fd4ac9eb8 ]--- Segmentation fault Notice the DATA BUS Error! The router is unusable at that point and no long= er "working". As for why this patch was coded this way. It's because this patch follows M= icha=C5=82 Kazior recommendation of how to handle this card in his reply to a previous thread= =20 "ath10k: reset chip after supported check" regarding the same issue. He did= check for a QCA988X Hardware and only then perform the SOC_CHIP_ID_ADDRESS read. |That makes sense, but I don't see how blacklisting pci slots would |help someone putting v2 nic into C7v1 mobo? Won't the slot be the same |regardless what nic is put? | |The best thing I can come up with is something like this: | |--- a/drivers/net/wireless/ath/ath10k/pci.c |+++ b/drivers/net/wireless/ath/ath10k/pci.c |@@ -3629,6 +3629,19 @@ static int ath10k_pci_probe(struct pci_dev *pdev, | goto err_deinit_irq; | } | |+ if (hw_rev =3D=3D ATH10K_HW_QCA988X) { |+ /* v1 can crash the system on chip_reset() |+ * so all we can do is keep our fingers |+ * crossed v2 never reports 0 without a |+ * chip_reset() |+ */ |+ if (ath10k_pci_soc_read32(ar, SOC_CHIP_ID_ADDRESS) =3D=3D = 0) { |+ ath10k_err(ar, "qca9880 v1 is chip not supported"); |+ ret =3D -ENOTSUP; |+ goto err_free_irq; |+ } |+ } |+ | ret =3D ath10k_pci_chip_reset(ar); | if (ret) { | ath10k_err(ar, "failed to reset chip: %d\n", ret); | |I didn't test it. Someone needs to compile and test and make sure v2 |doesn't regress when fw hangs and cold & warm host cpu resets are |mixed in. I do hope this helped "to clear things up" since I did not add support for the QCA9880 v1 AR1A here and don't plan to do so. Regards, Christian