From: "Nadolski, Edmund" <edmund.nadolski@intel.com>
To: Israel Rukshin <israelr@mellanox.com>,
Linux-nvme <linux-nvme@lists.infradead.org>,
Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>
Cc: Max Gurtovoy <maxg@mellanox.com>
Subject: Re: [PATCH 1/2] nvmet: Fix error print message at nvmet_install_queue function
Date: Tue, 4 Feb 2020 07:48:50 -0700 [thread overview]
Message-ID: <20bcbc11-2bfa-a3a9-5216-961ecbf6495e@intel.com> (raw)
In-Reply-To: <1580819890-11455-1-git-send-email-israelr@mellanox.com>
On 2/4/2020 5:38 AM, Israel Rukshin wrote:
> Place the arguments in the correct order.
>
> Fixes: 1672ddb8d691 ("nvmet: Add install_queue callout")
> Signed-off-by: Israel Rukshin <israelr@mellanox.com>
> Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
> ---
> drivers/nvme/target/fabrics-cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/target/fabrics-cmd.c b/drivers/nvme/target/fabrics-cmd.c
> index 7211996..53ef507 100644
> --- a/drivers/nvme/target/fabrics-cmd.c
> +++ b/drivers/nvme/target/fabrics-cmd.c
> @@ -136,7 +136,7 @@ static u16 nvmet_install_queue(struct nvmet_ctrl *ctrl, struct nvmet_req *req)
>
> if (ret) {
> pr_err("failed to install queue %d cntlid %d ret %x\n",
> - qid, ret, ctrl->cntlid);
> + qid, ctrl->cntlid, ret);
> return ret;
> }
> }
>
Looks good.
Ed
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-02-04 14:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 12:38 [PATCH 1/2] nvmet: Fix error print message at nvmet_install_queue function Israel Rukshin
2020-02-04 12:38 ` [PATCH 2/2] nvmet: Fix controller use after free Israel Rukshin
2020-02-04 14:49 ` Nadolski, Edmund
2020-02-04 16:03 ` Christoph Hellwig
2020-02-07 20:03 ` Sagi Grimberg
2020-02-04 14:48 ` Nadolski, Edmund [this message]
2020-02-04 15:59 ` [PATCH 1/2] nvmet: Fix error print message at nvmet_install_queue function Christoph Hellwig
2020-02-07 20:03 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20bcbc11-2bfa-a3a9-5216-961ecbf6495e@intel.com \
--to=edmund.nadolski@intel.com \
--cc=hch@lst.de \
--cc=israelr@mellanox.com \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.