From: "Paller, Kim Seer" <KimSeer.Paller@analog.com>
To: Jonathan Cameron <jic23@kernel.org>, Arnd Bergmann <arnd@arndb.de>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
kernel test robot <lkp@intel.com>,
"llvm@lists.linux.dev" <llvm@lists.linux.dev>,
"oe-kbuild-all@lists.linux.dev" <oe-kbuild-all@lists.linux.dev>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: RE: [jic23-iio:testing 6/10] drivers/iio/adc/max14001.c:135:13: warning: result of comparison of constant 18446744073709551615 with expression of type 'typeof (_Generic((mask), char: (unsigned char)0, unsigned char: (unsigned char)0, signed char: (unsi...
Date: Fri, 21 Jul 2023 07:36:33 +0000 [thread overview]
Message-ID: <20be2be0eaba4045a268407c1b6f07ad@analog.com> (raw)
In-Reply-To: <20230720191838.73473d2c@jic23-huawei>
>
> I'd prefer to just drop this reg_update function entirely. Put the call inline so
> that we can use FIELD_PREP() directly rather than (after fixing the probably
> bug) passing in both the value and the mask.
>
> >
> > but it looks like there is still a bug in max14001_reg_update(), so
> > I'd prefer Kim Seer Paller to revisit this issue and submit a properly
> > tested patch.
>
> Absolutely agree. If it's outstanding in few weeks though we can go
> with an educated 'guess' for the fix but I'd really rather not if Kim can post a fix
> in the meantime.
Thank you all for your input and feedback. I'm currently working on the fix and
will test it as soon as I have access to the eval boards again. I'll reach out if
something needs to be clarified.
Thanks,
Kim
prev parent reply other threads:[~2023-07-21 7:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 7:18 [jic23-iio:testing 6/10] drivers/iio/adc/max14001.c:135:13: warning: result of comparison of constant 18446744073709551615 with expression of type 'typeof (_Generic((mask), char: (unsigned char)0, unsigned char: (unsigned char)0, signed char: (unsigned char)0, unsigned short: (un kernel test robot
2023-06-21 8:25 ` Andy Shevchenko
2023-06-21 8:58 ` [jic23-iio:testing 6/10] drivers/iio/adc/max14001.c:135:13: warning: result of comparison of constant 18446744073709551615 with expression of type 'typeof (_Generic((mask), char: (unsigned char)0, unsigned char: (unsigned char)0, signed char: (unsi Paller, Kim Seer
2023-06-21 12:05 ` Jonathan Cameron
2023-06-22 12:52 ` Paller, Kim Seer
2023-07-21 8:38 ` Arnd Bergmann
2023-07-20 9:29 ` [jic23-iio:testing 6/10] drivers/iio/adc/max14001.c:135:13: warning: result of comparison of constant 18446744073709551615 with expression of type 'typeof (_Generic((mask), char: (unsigned char)0, unsigned char: (unsigned char)0, signed char: (unsigned char)0, unsigned short: (un Arnd Bergmann
2023-07-20 18:18 ` Jonathan Cameron
2023-07-20 18:22 ` Jonathan Cameron
2023-07-21 7:36 ` Paller, Kim Seer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20be2be0eaba4045a268407c1b6f07ad@analog.com \
--to=kimseer.paller@analog.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.