All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lazar, Lijo" <lijo.lazar@amd.com>
To: Mario Limonciello <mario.limonciello@amd.com>,
	amd-gfx@lists.freedesktop.org,
	Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [PATCH] drm/amd: Add the capability to mark certain firmware as "required"
Date: Wed, 4 Dec 2024 11:07:55 +0530	[thread overview]
Message-ID: <20d00e76-7ce4-42d0-a968-d7adae616984@amd.com> (raw)
In-Reply-To: <c5a7f27c-c676-4e10-83ba-393a4df06ada@amd.com>



On 12/4/2024 10:44 AM, Mario Limonciello wrote:
> 
>>> +enum amdgpu_ucode_required {
>>> +    AMDGPU_UCODE_NOT_REQUIRED,
>>> +    AMDGPU_UCODE_REQUIRED,
>>
>> Couldn't this be handled in another API instead of having to flag every
>> load? By default, every ucode is required and if optional may be skipped
>> with amdgpu_ucode_request_optional() API?
>>
> 
> I guess this would be a smaller patch, but 6 eggs one hand, half dozen
> in the other?
> 

I thought only ISP and gpu_info (no longer there for newer SOCs) fall
into the optional ones so far. The usage is rare, similar to the
nowarn() API usage.

Also, as far as I know, the cap microcode is a must whenever used. That
is not optional.

Thanks,
Lijo

> Alex - what's your take?


  reply	other threads:[~2024-12-04  5:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-03 18:14 [PATCH] drm/amd: Add the capability to mark certain firmware as "required" Mario Limonciello
2024-12-03 21:34 ` Alex Deucher
2024-12-03 21:38   ` Mario Limonciello
2024-12-04  3:35 ` Lazar, Lijo
2024-12-04  5:14   ` Mario Limonciello
2024-12-04  5:37     ` Lazar, Lijo [this message]
2024-12-04 14:21       ` Alex Deucher
2024-12-04 15:56         ` Lazar, Lijo
2024-12-04 16:00           ` Alex Deucher
2024-12-04 16:02             ` Mario Limonciello
2024-12-04 16:18             ` Lazar, Lijo
2024-12-04 16:45               ` Alex Deucher
2024-12-05  3:59                 ` Lazar, Lijo
2024-12-05  4:06                   ` Mario Limonciello
2024-12-05  4:30                     ` Lazar, Lijo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20d00e76-7ce4-42d0-a968-d7adae616984@amd.com \
    --to=lijo.lazar@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=mario.limonciello@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.