From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CF27C43458 for ; Tue, 7 Jul 2026 14:27:13 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wh6kj-00072e-8G; Tue, 07 Jul 2026 10:26:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wh6kh-00071l-6s for qemu-devel@nongnu.org; Tue, 07 Jul 2026 10:26:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wh6kf-00007r-8V for qemu-devel@nongnu.org; Tue, 07 Jul 2026 10:26:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783434379; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0Dg8a2Xx9lGaFNRVNAqYluwdyZYM5DInk2XYy+wrqDU=; b=iUouc4DLyARyc1654QbwHT7rPZ3u4M/2mMMCdE8KXrtEIAbowW+mp9IZgWr03VGuZMOOSB brwLUbK/aHXsD8LtIWIvYde2FSETfTHNX5oPXMjLi9KhACycOJGiYbPnW6b1Fa6e97k/82 yjTmXmbzXY3DymqkmxWQCspH6QNcED8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-517-6aGuqFDLOciiiOxc1lapcw-1; Tue, 07 Jul 2026 10:26:18 -0400 X-MC-Unique: 6aGuqFDLOciiiOxc1lapcw-1 X-Mimecast-MFC-AGG-ID: 6aGuqFDLOciiiOxc1lapcw_1783434377 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-490a767b782so33853635e9.2 for ; Tue, 07 Jul 2026 07:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783434377; x=1784039177; darn=nongnu.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=0Dg8a2Xx9lGaFNRVNAqYluwdyZYM5DInk2XYy+wrqDU=; b=TrRYVkEGS7fTBouKhZWhs+uSmUCWSB4Yu4Lt5SQX03o/BCpmAtEdz8zkKZbC0wXZLk y2ik9y+4Jv1kNAEWrQblB3zc/U3lA3t5CANyHz47fow1fN3yb/BKmRP53yuAR2B4+HfL uuL0FxG5DI4FzULHqF90YwqwoQE4jd7cqZ+CFhwWAzmep5fSk5gXphmcQ6z8V4Ok+hO7 Aa+90Bs5NcBI+C6CzdhlACAYBpXh8MkOprHSGei/i3leKzXo6gRo4CXvAdWDweBMlh6Y +Um/Hv2ORKgeYDfn5aNDazTWUR1aYC2o61LMHI+9O+UA2WaW1HWf7w8YIgpoDUGy8ANG x05g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783434377; x=1784039177; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=0Dg8a2Xx9lGaFNRVNAqYluwdyZYM5DInk2XYy+wrqDU=; b=AL0+evYPFa/lIoG/EgvraK25NSZMjBnU1veziiN9qaJzoW/YQGSU42H/Xnmhjx5gx+ gC8duuRrguvk3nrw6jBLIvX66a5HDILFNZsoVMQjeNpw7BftuUz5Tkz+kMcOeqkhWrSo EctB8/GdiWIvXvYjkoWjUSOCvhjxyVXeM/sUcNgPN9QNsVNJ8jpnY67uyGaqdHbJF+kL 2OBrxRetYbhqO/Xt0I+HqLImDr3OngGYRxAF1bK1MK86dPmfqVaBZXJhumlY1nP0JIXW 6nx3mMEpZEiRg9egeDpQUh7T2YSKCbUL/dpACgp9movwAmbrczBYs+EElYa/BwutOz3s 3Wsg== X-Forwarded-Encrypted: i=1; AHgh+RoCQpEFBrrrBT4g8PD6sOOED1GlnE3yDIp6qZJO5L6LDx7m28OiBmCPVTQZUOtknkXQyTGx8jLxCtvv@nongnu.org X-Gm-Message-State: AOJu0YyVh0jvINWemjJ5T9Z1xVDjalt26symvCjt2tM7FyJJPoIGaSt1 qhrlyx4qSbXi5wr5rnGNhDCjRlNclyJWkDDWStri2FlsZ38P01w8DBE7t3/H4c7ntlEYdoojtuQ tADSlFtjqd1ka5En+f4RoMfl9pS1uLhg63yj7DWs5gIQkaK+9kzwmTlO/ X-Gm-Gg: AfdE7clUlF0IfYw6HBbhXD4hSjDjsN7d9gPcUWGOlG++mkjPUhW33f/oH8UxyqDnZ64 h6bNac1WgvC0Q5uzO9I2umKEp82oay54uv5lX/DQHZ4aCRuNTUNx7o8tGGv8u7rtA/33piW99Nx l9xkuqI65MtNKivu4qngJt9BEfqV1ogaR9RvqfmJLRFjvErZvddnYpXPzpil2BHl6u7VHIy2W5V dybpq4LHWcE/h4PzC5V1sNeXpuNrWq51lYAYzJdYOuZA2lZPYUqKU3WaQpaGcmjcXt6for6Q903 3qYI2MjK813Vv/v979zB0zDrkbBHFDdLsYJyYNXTCtmLDaB0FiBCubc6TchFTLt+H1gYlOdt7UZ 4QAcGboSVoLJ69V5ZsgmFWZULnZyFF6Db0MCYGDbx0T2CkDkgGg== X-Received: by 2002:a7b:c00a:0:b0:493:bfbf:1da4 with SMTP id 5b1f17b1804b1-493df065f71mr43937475e9.22.1783434376801; Tue, 07 Jul 2026 07:26:16 -0700 (PDT) X-Received: by 2002:a7b:c00a:0:b0:493:bfbf:1da4 with SMTP id 5b1f17b1804b1-493df065f71mr43937155e9.22.1783434376309; Tue, 07 Jul 2026 07:26:16 -0700 (PDT) Received: from ?IPV6:2a01:e0a:280:24f0:576b:abc6:6396:ed4a? ([2a01:e0a:280:24f0:576b:abc6:6396:ed4a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493e0f294a6sm119677475e9.1.2026.07.07.07.26.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2026 07:26:15 -0700 (PDT) Message-ID: <20d58663-a8d1-41ff-9348-cae4982c30f0@redhat.com> Date: Tue, 7 Jul 2026 16:26:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 04/10] hw/block: m25p80: Fix dummy byte handling for Spansion flash From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Bin Meng , QEMU Cc: Alistair Francis , Hanna Reitz , Kevin Wolf , qemu-block@nongnu.org References: <20260707083431.219671-1-bin.meng@processmission.com> <20260707083431.219671-5-bin.meng@processmission.com> <92dd132e-e4d5-43f9-a207-c59697c87204@oss.qualcomm.com> <1e79dc11-0df2-47ac-a1c5-819398303e48@redhat.com> Content-Language: en-US, fr Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Bin, Philippe, On 7/7/26 16:05, Cédric Le Goater wrote: > >>> This breaks the test_arm_emcraft_sf2 functional test: >>> >>> not ok 1 test_emcraft_sf2.EmcraftSf2Machine.test_arm_emcraft_sf2 >>> >> >> >> No problem on my side. >> > Sorry. you are right ! It fails too. > > So we have a machine using a Spansion flash. > >     spi_flash = qdev_new("s25sl12801"); /* Spansion S25FL128SDPBHICO */ > > > C. Here is the fix. Feel free to merge in patch 4. Thanks, C. From 17ae23e5bc3629a5a301f14f47125f6f685ca9d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Date: Tue, 7 Jul 2026 16:23:29 +0200 Subject: [PATCH] hw/arm/msf2-som: Fix spansion-cr2nv value for S25FL128S MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The emcraft-sf2 board set spansion-cr2nv to 1, which the old m25p80 code treated as a byte count. With the dummy cycle to byte conversion fix, CR2V=1 at SPI x1 is 1 bit, not byte-aligned, and triggers an assertion. Use the S25FL128S default of 0x8 (8 cycles = 1 byte at SPI x1), preserving the same runtime behavior. Signed-off-by: Cédric Le Goater --- hw/arm/msf2-som.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/msf2-som.c b/hw/arm/msf2-som.c index caf6e7e1ad7d..1ada1a136130 100644 --- a/hw/arm/msf2-som.c +++ b/hw/arm/msf2-som.c @@ -84,7 +84,7 @@ static void emcraft_sf2_s2s010_init(MachineState *machine) /* Attach SPI flash to SPI0 controller */ spi_bus = qdev_get_child_bus(dev, "spi0"); spi_flash = qdev_new("s25sl12801"); /* Spansion S25FL128SDPBHICO */ - qdev_prop_set_uint8(spi_flash, "spansion-cr2nv", 1); + qdev_prop_set_uint8(spi_flash, "spansion-cr2nv", 0x8); if (dinfo) { qdev_prop_set_drive_err(spi_flash, "drive", blk_by_legacy_dinfo(dinfo), &error_fatal); -- 2.54.0