From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D07D9D58E7D for ; Mon, 2 Mar 2026 08:40:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:References:To:MIME-Version:Date: Message-ID:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YxzEakkPrY8bp2OjsBYrnI46GtMU4c3Eo3oHd1x99SE=; b=ZARrh2CU72o6JWIkGBjDLVew6c l2CXQMHzokPG7PCbBpVyCdgzWAqbxUOSKYhQvy9LaETueAtC2yC+QAjTZ2ezcA7SvCEq7BB/j1S/M khs4MYnPPB7YZo9KCa/T22CxXoNyohAgwsNVNFmHcng1Ze+O24Z62fj2zN0ejZ4nLqYE=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vwyox-000678-3y; Mon, 02 Mar 2026 08:40:07 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vwyov-00066P-AT for linux-f2fs-devel@lists.sourceforge.net; Mon, 02 Mar 2026 08:40:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=e6veCh/SKJpVIoMBxewv4OAAHnUrDVHhYJ0IaoIRGlA=; b=JT5Ik6s9yEjJ+zJG8GvZ5vZ1jR ul5ncox0l42jVgaAGdGfcRP0HtzCAfXqtLafjqX30qBDHx7M4W4B8w8t4F3Vvx4PP3MPozoyUXwaQ Gt0LHY1ZyMWIwuKoTcka4KRS6WZ/fnJzvRzlhcBNTaNeXgeur4EP6PD7KMxfX6fQ4vRw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=e6veCh/SKJpVIoMBxewv4OAAHnUrDVHhYJ0IaoIRGlA=; b=ZvA6jt+Cm3mOXcZy56V9CuweFn pOWRBCbSPKMHcYOXVWZvt6R9EtZUBjJTbU85aL007ymqxV5iIw8rte6tkDLAWYTXn4EBRxKimFSMi vTI3mgXJn3WvPUxKtHJHnX52qyycJKAg9cj/nPJA3pyRfmcHlMkOsnjM59yXqq2azxZA=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vwyou-0007MS-UI for linux-f2fs-devel@lists.sourceforge.net; Mon, 02 Mar 2026 08:40:05 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 8244840360; Mon, 2 Mar 2026 08:39:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCE99C19423; Mon, 2 Mar 2026 08:39:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772440794; bh=IK6yz5KkVHkPj52iCRrJqonMHigRB4kCqBYdPevwYOQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=rR6hqX6k7Jy2Fsq/qNTQTzsicRzKK5XKCMn38lSUnx79QM1kS0YTg+FZdrPkMHhAM xRPvlxsCD6cQ7hnoBGUd8fKi6lPHVSYnu198wRmEaOO7qtN1DTs/uXwmUi3YCIDUCs HvW95YTyPNv5VrWq0kLVxiuE+I2fMO7oWMOuu/Z8PHG5PLDCFmzza5g4Mq6FdMwfwk 5pLAmKlWAb3GNqbbp7VGzgnzcjHDwEoI65qHQk4nXNMC4EzvWhOKLaQEKojCQX++Fo Nmwq8cQ95fgGX+Bpr/QA7y3zMbx0y7W8w9wHiIFn0XBXFaFsSr6yHrEcGQ7Vrx/Iul d2CRZOgiHQyCQ== Message-ID: <20df8dd1-a32c-489d-8345-085d424a2f12@kernel.org> Date: Mon, 2 Mar 2026 09:39:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Qing Wang , syzbot+cae7809e9dc1459e4e63@syzkaller.appspotmail.com References: <698a26d3.050a0220.3b3015.007e.GAE@google.com> <20260302034102.3145719-1-wangqing7171@gmail.com> In-Reply-To: <20260302034102.3145719-1-wangqing7171@gmail.com> X-Headers-End: 1vwyou-0007MS-UI Subject: Re: [f2fs-dev] [syzbot] [mm?] [f2fs?] [exfat?] memory leak in __kfree_rcu_sheaf X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Vlastimil Babka \(SUSE\) via Linux-f2fs-devel" Reply-To: "Vlastimil Babka \(SUSE\)" Cc: lorenzo.stoakes@oracle.com, jannh@google.com, syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org, Liam.Howlett@oracle.com, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, Harry Yoo , Hao Li , pfalcato@suse.de, linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org, akpm@linux-foundation.org, sj1557.seo@samsung.com, linkinjeon@kernel.org, vbabka@suse.cz Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 3/2/26 04:41, Qing Wang wrote: > #syz test > > diff --git a/mm/slub.c b/mm/slub.c > index cdc1e652ec52..387979b89120 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -6307,15 +6307,21 @@ bool __kfree_rcu_sheaf(struct kmem_cache *s, void *obj) > goto fail; > > if (!local_trylock(&s->cpu_sheaves->lock)) { > - barn_put_empty_sheaf(barn, empty); > + if (barn && data_race(barn->nr_empty) < MAX_EMPTY_SHEAVES) > + barn_put_empty_sheaf(barn, empty); > + else > + free_empty_sheaf(s, empty); > goto fail; > } > > pcs = this_cpu_ptr(s->cpu_sheaves); > > - if (unlikely(pcs->rcu_free)) > - barn_put_empty_sheaf(barn, empty); > - else > + if (unlikely(pcs->rcu_free)) { > + if (barn && data_race(barn->nr_empty) < MAX_EMPTY_SHEAVES) > + barn_put_empty_sheaf(barn, empty); > + else > + free_empty_sheaf(s, empty); > + } else > pcs->rcu_free = empty; > } I don't think this would fix any leak, and syzbot agrees. It would limit the empty sheaves in barn more strictly, but they are not leaked. Hm I don't see any leak in __kfree_rcu_sheaf() or rcu_free_sheaf(). Wonder if kmemleak lacks visibility into barns or pcs's as roots for searching what objects are considered referenced, or something? _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5E0C38CFEE; Mon, 2 Mar 2026 08:39:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772440795; cv=none; b=U9uxERHCoLG+lpDTXkKhyIy/SI7N4ax1Ui19NjePiRxfD+9xb+Y0vB/QtQncwBQY6L8OxItajjnVHSDP/RrO1HraHfbsGQ3OaYLYzIsGGoLW1t4ywv2P/kfHEop611EjdIq0grLCdzRiRtUBSlb/q0w+sdbzqv9mzO30fPm2uio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772440795; c=relaxed/simple; bh=IK6yz5KkVHkPj52iCRrJqonMHigRB4kCqBYdPevwYOQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bSLqorcEJBY4z7rnrmfWR1y9KmCvKmAe77f4RyDIwz4zJWIUDm9obKQuLCeZx78t+n1nLsCee62Mwe4DzQFqW/zl+XLl3mf+IHAEjpQu47pQu6CT7fHcaUuPaTxzJhZdpIpYblFsoFigQ8PuL1juS1WGFlFd1vxG5cY0q8Zpe0o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rR6hqX6k; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rR6hqX6k" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCE99C19423; Mon, 2 Mar 2026 08:39:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772440794; bh=IK6yz5KkVHkPj52iCRrJqonMHigRB4kCqBYdPevwYOQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=rR6hqX6k7Jy2Fsq/qNTQTzsicRzKK5XKCMn38lSUnx79QM1kS0YTg+FZdrPkMHhAM xRPvlxsCD6cQ7hnoBGUd8fKi6lPHVSYnu198wRmEaOO7qtN1DTs/uXwmUi3YCIDUCs HvW95YTyPNv5VrWq0kLVxiuE+I2fMO7oWMOuu/Z8PHG5PLDCFmzza5g4Mq6FdMwfwk 5pLAmKlWAb3GNqbbp7VGzgnzcjHDwEoI65qHQk4nXNMC4EzvWhOKLaQEKojCQX++Fo Nmwq8cQ95fgGX+Bpr/QA7y3zMbx0y7W8w9wHiIFn0XBXFaFsSr6yHrEcGQ7Vrx/Iul d2CRZOgiHQyCQ== Message-ID: <20df8dd1-a32c-489d-8345-085d424a2f12@kernel.org> Date: Mon, 2 Mar 2026 09:39:48 +0100 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [mm?] [f2fs?] [exfat?] memory leak in __kfree_rcu_sheaf Content-Language: en-US To: Qing Wang , syzbot+cae7809e9dc1459e4e63@syzkaller.appspotmail.com Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, chao@kernel.org, jaegeuk@kernel.org, jannh@google.com, linkinjeon@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, pfalcato@suse.de, sj1557.seo@samsung.com, syzkaller-bugs@googlegroups.com, vbabka@suse.cz, Harry Yoo , Hao Li References: <698a26d3.050a0220.3b3015.007e.GAE@google.com> <20260302034102.3145719-1-wangqing7171@gmail.com> From: "Vlastimil Babka (SUSE)" In-Reply-To: <20260302034102.3145719-1-wangqing7171@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/2/26 04:41, Qing Wang wrote: > #syz test > > diff --git a/mm/slub.c b/mm/slub.c > index cdc1e652ec52..387979b89120 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -6307,15 +6307,21 @@ bool __kfree_rcu_sheaf(struct kmem_cache *s, void *obj) > goto fail; > > if (!local_trylock(&s->cpu_sheaves->lock)) { > - barn_put_empty_sheaf(barn, empty); > + if (barn && data_race(barn->nr_empty) < MAX_EMPTY_SHEAVES) > + barn_put_empty_sheaf(barn, empty); > + else > + free_empty_sheaf(s, empty); > goto fail; > } > > pcs = this_cpu_ptr(s->cpu_sheaves); > > - if (unlikely(pcs->rcu_free)) > - barn_put_empty_sheaf(barn, empty); > - else > + if (unlikely(pcs->rcu_free)) { > + if (barn && data_race(barn->nr_empty) < MAX_EMPTY_SHEAVES) > + barn_put_empty_sheaf(barn, empty); > + else > + free_empty_sheaf(s, empty); > + } else > pcs->rcu_free = empty; > } I don't think this would fix any leak, and syzbot agrees. It would limit the empty sheaves in barn more strictly, but they are not leaked. Hm I don't see any leak in __kfree_rcu_sheaf() or rcu_free_sheaf(). Wonder if kmemleak lacks visibility into barns or pcs's as roots for searching what objects are considered referenced, or something?