Re: [PATCH i-g-t 1/5] lib/kms: simplify igt_random_crtc()

["Sharma, Swati2" <swati2.sharma@intel.com>]

Hi Jani

On 18-06-2026 07:39 pm, Jani Nikula wrote:
> Now that igt_display_n_crtcs() reflects the actual number of CRTCs
> again, we no longer have to count them separately.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Patch LGTM

Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

> ---
>   lib/igt_kms.c | 9 ++-------
>   1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index e82d32130666..06138ad7125d 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -7922,16 +7922,11 @@ igt_crtc_t *igt_next_crtc(igt_display_t *display, igt_crtc_t *crtc)
>    */
>   igt_crtc_t *igt_random_crtc(igt_display_t *display)
>   {
> -	igt_crtc_t *crtcs[IGT_MAX_PIPES];
> -	igt_crtc_t *crtc;
> -	int n = 0;
> -
> -	for_each_crtc(display, crtc)
> -		crtcs[n++] = crtc;
> +	int n = igt_display_n_crtcs(display);
>   
>   	igt_skip_on_f(!n, "No CRTCs on device\n");
>   
> -	return crtcs[rand() % n];
> +	return igt_crtc_for_crtc_index(display, rand() % n);
>   }
>   
>   static drmModeConnectorPtr igt_wait_for_connector(int drm_fd, unsigned int connector_id,