From: Zhu Yanjun <yanjun.zhu@linux.dev>
To: Bob Pearson <rpearsonhpe@gmail.com>,
"lizhijian@fujitsu.com" <lizhijian@fujitsu.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Zhu Yanjun <zyjzyj2000@gmail.com>
Subject: Re: newlines in message macros
Date: Thu, 14 Sep 2023 07:12:04 +0800 [thread overview]
Message-ID: <20fb88a8-6c68-671c-7791-be1df6f708d6@linux.dev> (raw)
In-Reply-To: <1fbe7ebb-6501-10c4-b9eb-8435661f6046@gmail.com>
在 2023/9/14 4:50, Bob Pearson 写道:
> Li,
>
> I see that you removed the built-in newlines in the debug macros in rxe.h which is ok by me. But,
I made tests for many times about adding newline speeding up flush
messages. With or without new line, I can not find out the difference on
flushing messages. Not sure if Li Zhijian found this difference in a
specific scenario or not.
And even without new line, after output the line, the message still goes
to a new line. I suspect if a newline is appended in the PRINTK subsystem.
Zhu Yanjun
> for some reason the rxe_xxx() macros all still have built-in newlines. Why shouldn't we be consistent
> and make them all the same. (Maybe they don't get used much or at all.)
>
> Bob
next prev parent reply other threads:[~2023-09-13 23:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 20:50 newlines in message macros Bob Pearson
2023-09-13 21:10 ` Bob Pearson
2023-09-13 23:12 ` Zhu Yanjun [this message]
2023-09-14 12:52 ` Jason Gunthorpe
2023-09-15 1:38 ` Zhijian Li (Fujitsu)
2023-09-15 2:59 ` Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20fb88a8-6c68-671c-7791-be1df6f708d6@linux.dev \
--to=yanjun.zhu@linux.dev \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.