From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH 04/41] drm/rockchip: Respect page offset for PRIME mmap calls Date: Tue, 12 Dec 2017 17:58:24 +0100 Message-ID: <2101866.79D84rxXxt@phil> References: <20170310043305.17216-1-seanpaul@chromium.org> <20170310043305.17216-5-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170310043305.17216-5-seanpaul@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-rockchip@lists.infradead.org Cc: David Airlie , Tomasz Figa , dri-devel@lists.freedesktop.org, =?ISO-8859-1?Q?=D8rjan?= Eide , linux-arm-kernel@lists.infradead.org, Mark Yao List-Id: linux-rockchip.vger.kernel.org SGksCgpBbSBEb25uZXJzdGFnLCA5LiBNw6RyeiAyMDE3LCAyMzozMjoxOSBDRVQgc2NocmllYiBT ZWFuIFBhdWw6Cj4gRnJvbTogw5hyamFuIEVpZGUgPG9yamFuLmVpZGVAYXJtLmNvbT4KPiAKPiBX aGVuIG1hcHBpbmcgZXh0ZXJuYWwgRE1BLWJ1ZnMgdGhyb3VnaCB0aGUgUFJJTUUgbW1hcCBjYWxs LCB3ZSBtaWdodCBiZQo+IGdpdmVuIGFuIG9mZnNldCB3aGljaCBoYXMgdG8gYmUgcmVzcGVjdGVk LiBIb3dldmVyIGZvciB0aGUgaW50ZXJuYWwgRFJNCj4gR0VNIG1tYXAgcGF0aCwgd2UgaGF2ZSB0 byBpZ25vcmUgdGhlIGZha2UgbW1hcCBvZmZzZXQgdXNlZCB0byBpZGVudGlmeQo+IHRoZSBidWZm ZXIgb25seS4gQ3VycmVudGx5IHRoZSBjb2RlIGFsd2F5cyB6ZXJvZXMgb3V0IHZtYS0+dm1fcGdv ZmYsCj4gd2hpY2ggYnJlYWtzIHRoZSBmb3JtZXIuCj4gCj4gVGhpcyBwYXRjaCBmaXhlcyB0aGUg cHJvYmxlbSBieSBtb3ZpbmcgdGhlIHZtX3Bnb2ZmIGFzc2lnbm1lbnQgdG8gYQo+IGZ1bmN0aW9u IHRoYXQgaXMgdXNlZCBvbmx5IGZvciBHRU0gbW1hcCBwYXRoLCBzbyB0aGF0IHRoZSBQUklNRSBw YXRoCj4gcmV0YWlucyB0aGUgb3JpZ2luYWwgb2Zmc2V0Lgo+IAo+IEJVRz1jaHJvbWUtb3MtcGFy dG5lcjo1NjYxNQo+IFRFU1Q9Z3JhcGhpY3NfR0xCZW5jaAoKVW5uZWVkZWQgY2hyb21lb3MtY3J1 ZnQuCgo+IENjOiBEYW5pZWwgS3VydHogPGRqa3VydHpAY2hyb21pdW0ub3JnPgo+IFNpZ25lZC1v ZmYtYnk6IMOYcmphbiBFaWRlIDxvcmphbi5laWRlQGFybS5jb20+Cj4gU2lnbmVkLW9mZi1ieTog VG9tYXN6IEZpZ2EgPHRmaWdhQGNocm9taXVtLm9yZz4KPiBTaWduZWQtb2ZmLWJ5OiBTZWFuIFBh dWwgPHNlYW5wYXVsQGNocm9taXVtLm9yZz4KCldpdGggdGhlIHNhbWUgdGVzdGFzIHBhdGNoIDMg IChyazMzMjggKyBsaW1hKQpUZXN0ZWQtYnk6IEhlaWtvIFN0dWVibmVyIDxoZWlrb0BzbnRlY2gu ZGU+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Tue, 12 Dec 2017 17:58:24 +0100 Subject: [PATCH 04/41] drm/rockchip: Respect page offset for PRIME mmap calls In-Reply-To: <20170310043305.17216-5-seanpaul@chromium.org> References: <20170310043305.17216-1-seanpaul@chromium.org> <20170310043305.17216-5-seanpaul@chromium.org> Message-ID: <2101866.79D84rxXxt@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Am Donnerstag, 9. M?rz 2017, 23:32:19 CET schrieb Sean Paul: > From: ?rjan Eide > > When mapping external DMA-bufs through the PRIME mmap call, we might be > given an offset which has to be respected. However for the internal DRM > GEM mmap path, we have to ignore the fake mmap offset used to identify > the buffer only. Currently the code always zeroes out vma->vm_pgoff, > which breaks the former. > > This patch fixes the problem by moving the vm_pgoff assignment to a > function that is used only for GEM mmap path, so that the PRIME path > retains the original offset. > > BUG=chrome-os-partner:56615 > TEST=graphics_GLBench Unneeded chromeos-cruft. > Cc: Daniel Kurtz > Signed-off-by: ?rjan Eide > Signed-off-by: Tomasz Figa > Signed-off-by: Sean Paul With the same testas patch 3 (rk3328 + lima) Tested-by: Heiko Stuebner