From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
dev@dpdk.org, "Richardson, Bruce" <bruce.richardson@intel.com>,
"Wiles, Keith" <keith.wiles@intel.com>
Subject: Re: doc: deprecation notice for ethdev ops?
Date: Mon, 13 Feb 2017 18:38:04 +0100 [thread overview]
Message-ID: <2103008.ubY7H1HT7g@xps13> (raw)
In-Reply-To: <a4045879-5362-91e8-4e18-156938c74ea1@intel.com>
2017-02-13 16:46, Ferruh Yigit:
> On 2/13/2017 4:09 PM, Thomas Monjalon wrote:
> > 2017-02-13 16:02, Dumitrescu, Cristian:
> >> Hi Thomas,
> >>
> >> When a new member (function pointer) is added to struct eth_dev_ops (as the last member), does it need to go through ABI chance process (e.g. chance notice one release before)?
> >>
> >> IMO the answer is no: struct eth_dev_ops is marked as internal and its instances are only accessed through pointers, so the rte_eth_devices array should not be impacted by the ops structure expanding at its end. Unless there is something that I am missing?
> >
> > You are right, it is an internal struct.
> > So no need of a deprecation notice.
>
> When dpdk compiled as dynamic library, application will load PMDs
> dynamically as plugin.
> Is this use case cause ABI compatibility issue?
>
> I think drivers <--> libraries interface can cause ABI breakages for
> dynamic library case, although not sure how common use case this is.
Yes it is a problem for drivers/library interface.
It is not an ABI, which is an application/library interface.
prev parent reply other threads:[~2017-02-13 17:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 16:02 doc: deprecation notice for ethdev ops? Dumitrescu, Cristian
2017-02-13 16:09 ` Thomas Monjalon
2017-02-13 16:46 ` Ferruh Yigit
2017-02-13 17:21 ` Dumitrescu, Cristian
2017-02-13 17:36 ` Ferruh Yigit
2017-02-13 17:39 ` Thomas Monjalon
2017-02-13 17:38 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2103008.ubY7H1HT7g@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=keith.wiles@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.